From: Venkatesh Pallipadi <venki@google.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Kevin Hilman <khilman@ti.com>, Jean Pihet <j-pihet@ti.com>,
markgross <markgross@thegnar.org>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Venkatesh Pallipadi <venki@google.com>
Subject: [PATCH] CPU C-state breakage with PM Qos change
Date: Thu, 2 Feb 2012 15:57:45 -0800 [thread overview]
Message-ID: <1328227065-22045-1-git-send-email-venki@google.com> (raw)
Looks like change "PM QoS: Move and rename the implementation files"
made pm_qos depend on CONFIG_PM which depends on
PM_SLEEP || PM_RUNTIME
That breaks CPU C-states with kernels not having these CONFIGs, causing CPUs
to spend time in Polling loop idle instead of going into deep C-states,
consuming way way more power. This is with either acpi idle or intel idle
enabled.
Either CONFIG_PM should be enabled with any pm_qos users or
the !CONFIG_PM pm_qos_request() should return sane defaults not to break
the existing users. Here's is the patch for the latter option.
Signed-off-by: Venkatesh Pallipadi <venki@google.com>
---
include/linux/pm_qos.h | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
index 83b0ea3..84c99f4 100644
--- a/include/linux/pm_qos.h
+++ b/include/linux/pm_qos.h
@@ -107,7 +107,19 @@ static inline void pm_qos_remove_request(struct pm_qos_request *req)
{ return; }
static inline int pm_qos_request(int pm_qos_class)
- { return 0; }
+{
+ switch (pm_qos_class) {
+ case PM_QOS_CPU_DMA_LATENCY:
+ return PM_QOS_CPU_DMA_LAT_DEFAULT_VALUE;
+ case PM_QOS_NETWORK_LATENCY:
+ return PM_QOS_NETWORK_LAT_DEFAULT_VALUE;
+ case PM_QOS_NETWORK_LATENCY:
+ return PM_QOS_NETWORK_THROUGHPUT_DEFAULT_VALUE;
+ default:
+ return PM_QOS_DEFAULT_VALUE;
+ }
+}
+
static inline int pm_qos_add_notifier(int pm_qos_class,
struct notifier_block *notifier)
{ return 0; }
--
1.7.7.3
next reply other threads:[~2012-02-02 23:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 23:57 Venkatesh Pallipadi [this message]
2012-02-03 0:14 ` Venkatesh Pallipadi
2012-02-03 14:04 ` Pihet-XID, Jean
2012-02-03 20:02 ` Rafael J. Wysocki
2012-02-05 3:50 ` mark gross
2012-02-05 11:04 ` Rafael J. Wysocki
2012-02-06 10:18 ` [linux-pm] " Jean Pihet
2012-02-06 16:42 ` Jean Pihet
2012-02-06 20:16 ` Rafael J. Wysocki
2012-02-07 8:39 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328227065-22045-1-git-send-email-venki@google.com \
--to=venki@google.com \
--cc=j-pihet@ti.com \
--cc=khilman@ti.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@thegnar.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome