From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, tool: Fix perf stack to non executable on x86_64
Date: Fri, 03 Feb 2012 10:50:48 +0100 [thread overview]
Message-ID: <1328262648.2157.2.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <1328100848-5630-1-git-send-email-jolsa@redhat.com>
Le mercredi 01 février 2012 à 13:54 +0100, Jiri Olsa a écrit :
> By adding following objects:
> bench/mem-memset-x86-64-asm.o
> bench/mem-memcpy-x86-64-asm.o
> the x86_64 perf binary ended up with executable stack.
>
> The reason was that above objects are assembler sourced and
> are missing the GNU-stack note section. In such case the linker
> assumes that the final binary should not be restricted at all
> and mark the stack as RWX.
>
> Adding section ".note.GNU-stack" definition to mentioned objects,
> with all flags disabled, thus omiting those objects from linker
> stack flags decision.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> ---
Good catch, thanks !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2012-02-03 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 12:54 Jiri Olsa
2012-02-03 9:50 ` Eric Dumazet [this message]
2012-02-07 19:34 ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-02-07 19:37 ` [tip:perf/core] perf tool: " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328262648.2157.2.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®