From: Steven Rostedt <rostedt@goodmis.org>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Rob Herring <robherring2@gmail.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Kevin Hilman <khilman@ti.com>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 3/3][RFC] cpuidle/tracing: Denote the tracepoints as being in rcu_idle_exit() section
Date: Tue, 07 Feb 2012 15:49:45 -0500 [thread overview]
Message-ID: <1328647785.2200.112.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120207154009.GR5941@linux.vnet.ibm.com>
On Tue, 2012-02-07 at 07:40 -0800, Paul E. McKenney wrote:
> On Tue, Feb 07, 2012 at 09:56:56AM -0500, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@redhat.com>
> >
> > As the tracepoints in the cpuidle code are called when rcu_idle_exit() is in
> > effect, the _rcuidle() version must be used, otherwise the rcu_read_lock()s
> > that protect the tracepoint will not be honored.
> >
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> Looks good to me!
>
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Thanks, but does this include patch 2/3 as well?
-- Steve
next prev parent reply other threads:[~2012-02-07 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 14:56 [PATCH 0/3][RFC] tracing/rcu: Add _rcuidle() tracepoint to handle rcu_idle_exit() tracepoints Steven Rostedt
2012-02-07 14:56 ` [PATCH 1/3][RFC] tracing/rcu: Add trace_##name##__rcuidle() static tracepoint for inside rcu_idle_exit() sections Steven Rostedt
2012-02-07 14:56 ` [PATCH 2/3][RFC] x86/tracing: Denote the power and cpuidle tracepoints as _rcuidle() Steven Rostedt
2012-02-07 22:51 ` Paul E. McKenney
2012-02-07 14:56 ` [PATCH 3/3][RFC] cpuidle/tracing: Denote the tracepoints as being in rcu_idle_exit() section Steven Rostedt
2012-02-07 15:40 ` Paul E. McKenney
2012-02-07 20:49 ` Steven Rostedt [this message]
2012-02-07 15:37 ` [PATCH 0/3][RFC] tracing/rcu: Add _rcuidle() tracepoint to handle rcu_idle_exit() tracepoints Paul E. McKenney
2012-02-07 16:09 ` Steven Rostedt
2012-02-07 20:17 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328647785.2200.112.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=nicolas.pitre@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®