From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: adobriyan@gmail.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reduce the number of expensive division instructions done by _parse_integer()
Date: Thu, 09 Feb 2012 17:42:02 +0100 [thread overview]
Message-ID: <1328805722.6099.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <1328804920.6099.3.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Le jeudi 09 février 2012 à 17:28 +0100, Eric Dumazet a écrit :
> You could avoid the divide and have cleaner code I think.
>
> unsigned long long next = *res * base + val;
>
> if (next < *res)
> overflow = 1;
> *res = next;
>
Oh well, this one is better.
unsigned long long next = *res * base;
if (next < *res)
overflow = 1;
*res = next + val;
next prev parent reply other threads:[~2012-02-09 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 15:48 David Howells
2012-02-09 16:28 ` Eric Dumazet
2012-02-09 16:42 ` Eric Dumazet [this message]
2012-02-09 16:58 ` Linus Torvalds
2012-02-09 17:08 ` Linus Torvalds
2012-02-09 17:46 ` David Howells
2012-02-09 17:56 ` Linus Torvalds
2012-02-09 18:07 ` David Howells
2012-02-09 18:08 ` Linus Torvalds
2012-02-09 18:50 ` David Howells
2012-02-09 19:14 ` Linus Torvalds
2012-02-10 13:50 ` Alexey Dobriyan
2012-02-09 19:23 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328805722.6099.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=adobriyan@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®