From: Danny Kukawka <danny.kukawka@bisect.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Danny Kukawka <dkukawka@suse.de>,
Michael Hennerich <michael.hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] adis16080: fix compiler -Wuninitialized
Date: Tue, 14 Feb 2012 15:35:36 +0100 [thread overview]
Message-ID: <1329230136-26576-1-git-send-email-danny.kukawka@bisect.de> (raw)
Fix for:
drivers/staging/iio/gyro/adis16080_core.c: In function
‘adis16080_read_raw’:
drivers/staging/iio/gyro/adis16080_core.c:99:8: warning: ‘ut’
may be used uninitialized in this function [-Wuninitialized]
Initialize ut and change error handling from adis16080_read_raw().
Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
drivers/staging/iio/gyro/adis16080_core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/gyro/adis16080_core.c b/drivers/staging/iio/gyro/adis16080_core.c
index 1815490..e0b2a29 100644
--- a/drivers/staging/iio/gyro/adis16080_core.c
+++ b/drivers/staging/iio/gyro/adis16080_core.c
@@ -82,7 +82,7 @@ static int adis16080_read_raw(struct iio_dev *indio_dev,
long mask)
{
int ret = -EINVAL;
- u16 ut;
+ u16 ut = 0;
/* Take the iio_dev status lock */
mutex_lock(&indio_dev->mlock);
@@ -94,7 +94,7 @@ static int adis16080_read_raw(struct iio_dev *indio_dev,
if (ret < 0)
break;
ret = adis16080_spi_read(indio_dev, &ut);
- if (ret < 0)
+ if (ret)
break;
*val = ut;
ret = IIO_VAL_INT;
--
1.7.7.3
next reply other threads:[~2012-02-14 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 14:35 Danny Kukawka [this message]
2012-02-14 15:04 ` Dan Carpenter
2012-02-14 15:18 ` Jonathan Cameron
2012-02-14 17:36 ` Danny Kukawka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329230136-26576-1-git-send-email-danny.kukawka@bisect.de \
--to=danny.kukawka@bisect.de \
--cc=devel@driverdev.osuosl.org \
--cc=dkukawka@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®