From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Lameter <cl@linux.com>, Tejun Heo <tj@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] percpu: use raw_local_irq_* in _this_cpu op
Date: Wed, 15 Feb 2012 05:59:07 +0100 [thread overview]
Message-ID: <1329281947.2555.26.camel@edumazet-laptop> (raw)
In-Reply-To: <1329280586-6878-1-git-send-email-tom.leiming@gmail.com>
Le mercredi 15 février 2012 à 12:36 +0800, Ming Lei a écrit :
> It doesn't make sense to trace irq off or do irq flags
> lock proving inside 'this_cpu' operations, so replace local_irq_*
> with raw_local_irq_* in 'this_cpu' op.
...
> Acked-by: Christoph Lameter <cl@linux.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> include/linux/percpu.h | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/percpu.h b/include/linux/percpu.h
> index 6e68d05..5ed1e38 100644
> --- a/include/linux/percpu.h
> +++ b/include/linux/percpu.h
> @@ -294,9 +294,9 @@ do { \
> #define _this_cpu_generic_to_op(pcp, val, op) \
> do { \
> unsigned long flags; \
> - local_irq_save(flags); \
> + raw_local_irq_save(flags); \
> *__this_cpu_ptr(&(pcp)) op val; \
> - local_irq_restore(flags); \
> + raw_local_irq_restore(flags); \
> } while (0)
>
Could you check the alignement of trailing '\' ?
next prev parent reply other threads:[~2012-02-15 4:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 4:36 Ming Lei
2012-02-15 4:59 ` Eric Dumazet [this message]
2012-02-15 5:08 ` Ming Lei
2012-02-15 6:03 ` Eric Dumazet
2012-02-15 8:56 ` Ming Lei
2012-02-15 8:54 Ming Lei
2012-02-21 17:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329281947.2555.26.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®