From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591Ab2BVJc0 (ORCPT ); Wed, 22 Feb 2012 04:32:26 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60026 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877Ab2BVJcX (ORCPT ); Wed, 22 Feb 2012 04:32:23 -0500 X-Sasl-enc: THwTuShGwCN4rI2miDNS/07uyd7G8Xiq0mXOzHW7wn+wyBcOs5E9DLjF9A 1329903142 Message-ID: <1329903139.2193.66.camel@perseus.themaw.net> Subject: Re: compat: autofs v5 packet size ambiguity - update From: Ian Kent To: Linus Torvalds Cc: David Miller , linux-kernel@vger.kernel.org, "H. Peter Anvin" , autofs@vger.kernel.org, Thomas Meyer , Al Viro Date: Wed, 22 Feb 2012 17:32:19 +0800 In-Reply-To: <1329890251.2193.50.camel@perseus.themaw.net> References: <20120221.221609.218135609185671883.davem@davemloft.net> <1329889428.2193.45.camel@perseus.themaw.net> <1329890027.2193.48.camel@perseus.themaw.net> <1329890251.2193.50.camel@perseus.themaw.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-02-22 at 13:57 +0800, Ian Kent wrote: > On Wed, 2012-02-22 at 13:53 +0800, Ian Kent wrote: > > On Wed, 2012-02-22 at 13:43 +0800, Ian Kent wrote: > > > On Tue, 2012-02-21 at 20:56 -0800, Linus Torvalds wrote: > > > > Ahh ... forgot to set the file_operations structure member .. oops > > > > > > > > +static int autofs4_root_dir_open(struct inode *inode, struct file *file) > > > +{ > > > + struct autofs_sb_info *sbi= autofs4_sbi(file->f_path.dentry->d_sb); > > > + if (sbi->compat_daemon < 0) > > > + sbi->compat_daemon = is_compat_task(); > > > + return dcache_dir_open(inode, file); > > > +} > > > + > > > > Lets try that again. Oh, DOH ... The process mounting the autofs mount is passing the pipe it will use for communication via a mount option so we can do this right in fill_super. I'm out for a while, I'll update the patch when I'm back. Ian