mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Borislav Petkov <bp@amd64.org>,
	"Luck, Tony" <tony.luck@intel.com>, Ingo Molnar <mingo@elte.hu>,
	edac-devel <linux-edac@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: RAS trace event proto
Date: Wed, 22 Feb 2012 09:26:34 -0500	[thread overview]
Message-ID: <1329920794.25686.95.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4F44EE60.8030400@redhat.com>

On Wed, 2012-02-22 at 11:32 -0200, Mauro Carvalho Chehab wrote:

> @Steven:
> 
> In a matter of fact, the error_severity and error_type should be enum's. We should not
> use enum's on ioctl's, as enum size is not portable. Can it be used inside perf, or should
> them be exported, on perf, via integer (like the above proposal)?

I don't know exactly how perf does it today, but I'm sure it's similar
to trace-cmd.

You can use an enum, as it just comes through as a number. Each field is
given the size of that field. If it's an int it stays an int.

Note though, perf and trace-cmd do not know how to convert the number
back to a enum name. You can use the __print_symbols() feature, but
that's about it.

-- Steve



  parent reply	other threads:[~2012-02-22 14:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 14:59 Borislav Petkov
2012-02-21  1:14 ` Steven Rostedt
2012-02-21 10:15   ` Borislav Petkov
2012-02-21 12:24 ` Mauro Carvalho Chehab
2012-02-21 14:12   ` Borislav Petkov
2012-02-21 14:48     ` Steven Rostedt
2012-02-21 14:59       ` Borislav Petkov
2012-02-21 16:18         ` Mauro Carvalho Chehab
2012-02-22  0:58         ` Luck, Tony
2012-02-22 10:43           ` Borislav Petkov
2012-02-22 12:02             ` Mauro Carvalho Chehab
2012-02-22 12:25               ` Borislav Petkov
2012-02-22 13:32                 ` Mauro Carvalho Chehab
2012-02-22 14:05                   ` Borislav Petkov
2012-02-22 14:25                     ` Mauro Carvalho Chehab
2012-02-22 14:26                   ` Steven Rostedt [this message]
2012-02-22 15:59             ` Borislav Petkov
2012-02-27 15:54               ` Borislav Petkov
2012-02-21 17:28     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329920794.25686.95.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=bp@amd64.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=mingo@elte.hu \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®