From: Dipen Patel <dipenp@nvidia.com>
To: Rob Herring <robh@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: devicetree@vger.kernel.org, timestamp@lists.linux.dev,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hte: Explicitly include correct DT includes
Date: Thu, 27 Jul 2023 14:57:39 -0700 [thread overview]
Message-ID: <132d5dc1-6104-1d2e-543a-e92177b01fae@nvidia.com> (raw)
In-Reply-To: <20230714174600.4057041-1-robh@kernel.org>
On 7/14/23 10:46 AM, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/hte/hte-tegra194.c | 1 -
> drivers/hte/hte.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 06ef349a2265..6fe6897047ac 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -12,7 +12,6 @@
> #include <linux/stat.h>
> #include <linux/interrupt.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/hte.h>
> #include <linux/uaccess.h>
> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
> index 67c15724ee78..598a716b7364 100644
> --- a/drivers/hte/hte.c
> +++ b/drivers/hte/hte.c
> @@ -10,12 +10,12 @@
> #include <linux/err.h>
> #include <linux/slab.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/mutex.h>
> #include <linux/uaccess.h>
> #include <linux/hte.h>
> #include <linux/delay.h>
> #include <linux/debugfs.h>
> +#include <linux/device.h>
>
> #define HTE_TS_NAME_LEN 10
>
Acked-by: Dipen Patel <dipenp@nvidia.com>
prev parent reply other threads:[~2023-07-27 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 17:46 Rob Herring
2023-07-27 21:57 ` Dipen Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132d5dc1-6104-1d2e-543a-e92177b01fae@nvidia.com \
--to=dipenp@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®