From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752455AbdKXGlz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 01:41:55 -0500
Received: from mga04.intel.com ([192.55.52.120]:16343 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751643AbdKXGly (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 01:41:54 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,445,1505804400"; 
   d="scan'208";a="1247879132"
Subject: Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from
 userspace page tables
To: Ingo Molnar <mingo@kernel.org>
References: <20171123003438.48A0EEDE@viggo.jf.intel.com>
 <c55957c0-cf1a-eb8d-c37a-c2b69ada2312@linux.intel.com>
 <20171124063514.36xlqnh5seszy4nu@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        moritz.lipp@iaik.tugraz.at, daniel.gruss@iaik.tugraz.at,
        michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at,
        luto@kernel.org, torvalds@linux-foundation.org, keescook@google.com,
        hughd@google.com, x86@kernel.org, jgross@suse.com
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <132d8ad8-a85f-5184-2dee-39a47e22e1ff@linux.intel.com>
Date: Thu, 23 Nov 2017 22:41:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171124063514.36xlqnh5seszy4nu@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/23/2017 10:35 PM, Ingo Molnar wrote:
> So the pteval_t changes break the build on most non-x86 architectures (alpha, arm, 
> arm64, etc.), because most of them don't have an asm/pgtable_types.h file.
> 
> pteval_t is an x86-ism.
> 
> So I left out the changes below.

There was a warning on the non-PAE 32-bit builds saying that there was a
shift larger than the type.  I assumed this was because of a reference
to _PAGE_NX, and thus we needed a change to pteval_t.

But, now that I think about it more, that doesn't make sense since
_PAGE_NX should be #defined down to a 0 on those configs unless
something is wrong.