mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Gerlando Falauto <gerlando.falauto@keymile.com>
Cc: holger.brunck@keymile.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: don't select FRAME_POINTER on PPC
Date: Mon, 27 Feb 2012 08:37:11 -0500	[thread overview]
Message-ID: <1330349831.25686.188.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1330330101-8618-1-git-send-email-gerlando.falauto@keymile.com>

On Mon, 2012-02-27 at 09:08 +0100, Gerlando Falauto wrote:
> On PowerPC, FUNCTION_TRACER selects FRAME_POINTER, even
> though the architecture does not support it.
> 
> This causes the following warning:
> warning: (LOCKDEP && FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && FUNCTION_TRACER && KMEMCHECK) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300) || ARCH_WANT_FRAME_POINTERS)
> 
> So remove the warning by adding the extra condition
> "if !PPC" to FUNCTION_TRACER for FRAME_POINTER selection

I'll queue it up for 3.4, if that's fine with you.

Thanks,

-- Steve

> 
> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
> ---
>  kernel/trace/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 2ad39e5..fbdec2e 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -141,7 +141,7 @@ if FTRACE
>  config FUNCTION_TRACER
>  	bool "Kernel Function Tracer"
>  	depends on HAVE_FUNCTION_TRACER
> -	select FRAME_POINTER if !ARM_UNWIND && !S390 && !MICROBLAZE
> +	select FRAME_POINTER if !ARM_UNWIND && !PPC && !S390 && !MICROBLAZE
>  	select KALLSYMS
>  	select GENERIC_TRACER
>  	select CONTEXT_SWITCH_TRACER



  reply	other threads:[~2012-02-27 13:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27  8:08 Gerlando Falauto
2012-02-27 13:37 ` Steven Rostedt [this message]
2012-03-22 21:17 ` [tip:perf/urgent] tracing: Do not " tip-bot for Gerlando Falauto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330349831.25686.188.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=gerlando.falauto@keymile.com \
    --cc=holger.brunck@keymile.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®