From: Joe Perches <joe@perches.com>
To: Jiri Slaby <jslaby@suse.cz>, netdev <netdev@vger.kernel.org>,
Karsten Keil <isdn@linux-pingi.de>
Cc: Jiri Slaby <jirislaby@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Hansjoerg Lipp <hjlipp@web.de>, Tilman Schmidt <tilman@imap.cc>,
gigaset307x-common@lists.sourceforge.net,
David Miller <davem@davemloft.net>
Subject: [PATCH net-next] gigaset: Use semicolons to terminate statements
Date: Mon, 27 Feb 2012 09:39:27 -0800 [thread overview]
Message-ID: <1330364367.9942.21.camel@joe2Laptop> (raw)
In-Reply-To: <1330363627.9942.16.camel@joe2Laptop>
Commas are not generally used at locations where
statement termination semicolons are used.
Realign each field set at appropriate indentation.
Signed-off-by: Joe Perches <joe@perches.com>
---
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index da2486e..91f99e4 100644
@@ -679,10 +679,10 @@ void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname,
if (tty == NULL)
goto enomem;
- tty->magic = TTY_DRIVER_MAGIC,
- tty->type = TTY_DRIVER_TYPE_SERIAL,
- tty->subtype = SERIAL_TYPE_NORMAL,
- tty->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
+ tty->magic = TTY_DRIVER_MAGIC;
+ tty->type = TTY_DRIVER_TYPE_SERIAL;
+ tty->subtype = SERIAL_TYPE_NORMAL;
+ tty->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
tty->driver_name = procname;
tty->name = devname;
next prev parent reply other threads:[~2012-02-27 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 8:59 "whitespace coding style cleanup" broke coding style Jiri Slaby
2012-02-27 11:19 ` Tilman Schmidt
2012-02-27 11:34 ` Jiri Slaby
2012-02-27 16:52 ` Joe Perches
2012-02-27 17:12 ` Jiri Slaby
2012-02-27 17:27 ` Joe Perches
2012-02-27 17:39 ` Joe Perches [this message]
2012-02-27 19:12 ` [PATCH net-next] gigaset: Use semicolons to terminate statements David Miller
2012-02-27 18:58 ` "whitespace coding style cleanup" broke coding style Jiri Slaby
2012-02-28 17:58 ` Tilman Schmidt
2012-02-28 22:05 ` Joe Perches
2012-02-28 23:08 ` Tilman Schmidt
2012-02-28 23:28 ` Joe Perches
2012-02-28 23:42 ` David Miller
2012-02-29 0:41 ` Alan Cox
2012-02-29 8:27 ` Armin Schindler
2012-02-29 19:32 ` Joe Perches
2012-02-29 11:05 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330364367.9942.21.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn@linux-pingi.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome