From: Fabio Estevam <festevam@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: dan.j.williams@intel.com, vinod.koul@intel.com,
kernel@pengutronix.de, shawn.guo@freescale.com,
Fabio Estevam <festevam@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH 2/2] dma: imx-sdma: Print a message when firmare fails to be requested
Date: Wed, 29 Feb 2012 11:20:38 -0300 [thread overview]
Message-ID: <1330525238-25420-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1330525238-25420-1-git-send-email-festevam@gmail.com>
Print a message when firmare fails to be requested in the case of platform data being used.
While at it, distinguish between the error messages of the device tree and platform data cases.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/imx-sdma.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 130b994..f0bfc0e 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1388,7 +1388,9 @@ static int __init sdma_probe(struct platform_device *pdev)
sdma_add_scripts(sdma, pdata->script_addrs);
if (pdata) {
- sdma_get_firmware(sdma, pdata->fw_name);
+ ret = sdma_get_firmware(sdma, pdata->fw_name);
+ if (ret)
+ dev_err(&pdev->dev, "failed to get firmware from platform data\n");
} else {
/*
* Because that device tree does not encode ROM script address,
@@ -1402,7 +1404,7 @@ static int __init sdma_probe(struct platform_device *pdev)
else {
ret = sdma_get_firmware(sdma, fw_name);
if (ret)
- dev_err(&pdev->dev, "failed to get firmware\n");
+ dev_err(&pdev->dev, "failed to get firmware from device tree\n");
}
}
--
1.7.1
next prev parent reply other threads:[~2012-02-29 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 14:20 [PATCH 1/2] dma: imx-sdma: Let the driver be probed even if no firware is found Fabio Estevam
2012-02-29 14:20 ` Fabio Estevam [this message]
2012-03-02 7:21 ` Sascha Hauer
2012-03-06 12:04 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330525238-25420-2-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®