From: Eugene Surovegin <surovegin@google.com>
To: linux-kernel@vger.kernel.org
Cc: Eugene Surovegin <surovegin@google.com>,
Eric Biederman <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>,
kexec-list <kexec@lists.infradead.org>
Subject: [PATCH] kdump: force page alignment for per-CPU crash notes.
Date: Wed, 29 Feb 2012 09:21:23 -0800 [thread overview]
Message-ID: <1330536083-13098-1-git-send-email-surovegin@google.com> (raw)
Per-CPU allocations are not guaranteed to be physically contiguous.
However, kdump kernel and user-space code assumes that per-CPU
memory, used for saving CPU registers on crash, is.
This can cause corrupted /proc/vmcore in some cases - the main
symptom being huge ELF note section.
Force page alignment for note_buf_t to ensure that this assumption holds.
Signed-off-by: Eugene Surovegin <surovegin@google.com>
CC: Eric Biederman <ebiederm@xmission.com>
CC: Vivek Goyal <vgoyal@redhat.com>
CC: kexec-list <kexec@lists.infradead.org>
---
kernel/kexec.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 7b08867..e641b5c 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1232,8 +1232,13 @@ void crash_save_cpu(struct pt_regs *regs, int cpu)
static int __init crash_notes_memory_init(void)
{
- /* Allocate memory for saving cpu registers. */
- crash_notes = alloc_percpu(note_buf_t);
+ /* Allocate memory for saving cpu registers.
+ * Force page alignment to avoid crossing physical page boundary -
+ * kexec-tools and kernel /proc/vmcore handler assume these per-CPU
+ * chunks are physically contiguous.
+ */
+ crash_notes = (note_buf_t __percpu *)__alloc_percpu(sizeof(note_buf_t),
+ PAGE_SIZE);
if (!crash_notes) {
printk("Kexec: Memory allocation for saving cpu register"
" states failed\n");
--
1.7.9.1
next reply other threads:[~2012-02-29 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:21 Eugene Surovegin [this message]
2012-03-01 1:18 ` Simon Horman
[not found] ` <CANrfoUXd4L2bjBO+L8ZBCkc1dfnZahn39sB25zsrUMqGA5zY5A@mail.gmail.com>
2012-03-01 1:32 ` Simon Horman
2012-03-01 1:39 ` Eugene Surovegin
2012-03-01 1:51 ` HATAYAMA Daisuke
2012-03-01 1:56 ` Eugene Surovegin
2012-03-01 2:50 ` Simon Horman
2012-03-01 2:53 ` Simon Horman
2012-03-01 15:09 ` Vivek Goyal
2012-03-01 17:04 ` Eugene Surovegin
2012-03-01 18:31 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330536083-13098-1-git-send-email-surovegin@google.com \
--to=surovegin@google.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®