From: Alexander Graf <agraf@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Thomas Meyer <thomas@m3y3r.de>, Ian Kent <raven@themaw.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Mahoney <jeffm@suse.de>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] autofs: fix compilation on hosts without CONFIG_COMPAT
Date: Sat, 3 Mar 2012 00:37:40 +0100 [thread overview]
Message-ID: <1330731460-24727-1-git-send-email-agraf@suse.de> (raw)
When compiling 3.3-rc5 on arm, I get the following compilation error:
fs/autofs4/inode.c: In function 'autofs4_fill_super':
fs/autofs4/inode.c:228:2: error: implicit declaration of function 'is_compat_task' [-Werror=implicit-function-declaration]
which was introduced by commit a32744d4a. On platforms that don't define
CONFIG_COMPAT, using is_compat_task() is not necessarily defined. So
let's just not use it there.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
Sorry if this was already fixed elsewhere - I couldn't find a patch for it, but
my LKML searching skills are slightly limited :)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 85f1fcd..bab4c5a 100644
--- a/fs/autofs4/dev-ioctl.c
+++ b/fs/autofs4/dev-ioctl.c
@@ -385,7 +385,11 @@ static int autofs_dev_ioctl_setpipefd(struct file *fp,
sbi->pipefd = pipefd;
sbi->pipe = pipe;
sbi->catatonic = 0;
+#ifdef CONFIG_COMPAT
sbi->compat_daemon = is_compat_task();
+#else
+ sbi->compat_daemon = 0;
+#endif
}
out:
mutex_unlock(&sbi->wq_mutex);
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 06858d9..1fc68e7 100644
--- a/fs/autofs4/inode.c
+++ b/fs/autofs4/inode.c
@@ -225,7 +225,11 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
set_autofs_type_indirect(&sbi->type);
sbi->min_proto = 0;
sbi->max_proto = 0;
+#ifdef CONFIG_COMPAT
sbi->compat_daemon = is_compat_task();
+#else
+ sbi->compat_daemon = 0;
+#endif
mutex_init(&sbi->wq_mutex);
mutex_init(&sbi->pipe_mutex);
spin_lock_init(&sbi->fs_lock);
reply other threads:[~2012-03-02 23:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330731460-24727-1-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=jeffm@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®