mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Estevam Fabio-R49496 <r49496@freescale.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 1/4] regulator fixed: Do not report enumaratable voltages if there are none
Date: Sat,  3 Mar 2012 12:40:01 +0100	[thread overview]
Message-ID: <1330774804-7310-2-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1330774804-7310-1-git-send-email-s.hauer@pengutronix.de>

If used as a dummy voltage provider the fixed regulator should
not set n_voltages to make the core accept the device.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/regulator/fixed.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index e24e3a1..40f3803 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -192,7 +192,9 @@ static int __devinit reg_fixed_voltage_probe(struct platform_device *pdev)
 	drvdata->desc.type = REGULATOR_VOLTAGE;
 	drvdata->desc.owner = THIS_MODULE;
 	drvdata->desc.ops = &fixed_voltage_ops;
-	drvdata->desc.n_voltages = 1;
+
+	if (config->microvolts)
+		drvdata->desc.n_voltages = 1;
 
 	drvdata->microvolts = config->microvolts;
 	drvdata->gpio = config->gpio;
-- 
1.7.9.1


  reply	other threads:[~2012-03-03 11:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-03 11:40 [PATCH] Add helper for registering a fixed regulator Sascha Hauer
2012-03-03 11:40 ` Sascha Hauer [this message]
2012-03-03 12:56   ` [PATCH 1/4] regulator fixed: Do not report enumaratable voltages if there are none Mark Brown
2012-03-03 11:40 ` [PATCH 2/4] regulator: provide a helper for registering a fixed regulator Sascha Hauer
2012-03-03 16:33   ` Mark Brown
2012-03-03 11:40 ` [PATCH 3/4] ARM i.MX pcm037: register a dummy regulator for the smsc911x device Sascha Hauer
2012-03-03 16:34   ` Mark Brown
2012-03-03 11:40 ` [PATCH 4/4] ARM i.MX 3ds debugboard: " Sascha Hauer
2012-03-03 16:37   ` Mark Brown
2012-03-03 18:14     ` Sascha Hauer
2012-03-26 18:09   ` Fabio Estevam
2012-03-26 18:19     ` Sascha Hauer
2012-03-26 18:25       ` Fabio Estevam
2012-03-26 18:38         ` Fabio Estevam
2012-03-26 18:48           ` Fabio Estevam
2012-03-28 10:57       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330774804-7310-2-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=r49496@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®