From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, ohering@suse.com,
hch@infradead.org, linux-scsi@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Don't pass ATA_16 command to the host
Date: Sun, 04 Mar 2012 08:19:30 -0600 [thread overview]
Message-ID: <1330870770.2858.4.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1330721347-26781-1-git-send-email-kys@microsoft.com>
On Fri, 2012-03-02 at 12:49 -0800, K. Y. Srinivasan wrote:
> Windows hosts don't handle the ATA_16 command; don't pass it to the host.
What do you mean by this? Most SCSI devices don't handle ATA_16 because
it's only useful if the device is actually an ATA device behind a
bridge.
As a general rule, you shouldn't filter in the driver commands you think
the host won't want to see, you should let the host reply with an error
code. You should *only* filter commands that cause an actual bug in the
host. Is the latter the case for this command (if so that needs to be
explained)?
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
This signoff chain doesn't make sense, since you're sending me the patch
and apparently you authored it.
James
next prev parent reply other threads:[~2012-03-04 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 20:49 K. Y. Srinivasan
2012-03-02 21:13 ` Greg KH
2012-03-02 21:22 ` KY Srinivasan
2012-03-02 21:31 ` Greg KH
2012-03-02 21:33 ` KY Srinivasan
2012-03-04 9:12 ` Christoph Hellwig
2012-03-04 14:23 ` KY Srinivasan
2012-03-04 14:48 ` James Bottomley
2012-03-05 2:29 ` KY Srinivasan
2012-03-15 23:03 ` KY Srinivasan
2012-03-04 14:19 ` James Bottomley [this message]
2012-03-04 23:15 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330870770.2858.4.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®