mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "viro@ZenIV.linux.org.uk" <viro@ZenIV.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH 9/9] nfs: don't open in ->d_revalidate
Date: Tue, 6 Mar 2012 17:47:48 +0000	[thread overview]
Message-ID: <1331056067.10560.26.camel@lade.trondhjem.org> (raw)
In-Reply-To: <87y5rdirj2.fsf@tucsk.pomaz.szeredi.hu>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 997 bytes --]

On Tue, 2012-03-06 at 18:10 +0100, Miklos Szeredi wrote:
> "Myklebust, Trond" <Trond.Myklebust@netapp.com> writes:
> 
> > It makes a big difference to the cache miss case, since not only is the
> > entire path looked up again, but the LOOKUP_REVAL flag gets set, which
> > forces a full lookup of each component (as opposed to just
> > revalidating).
> 
> This is not about a cache miss.  It's about a cache hit (positive cached
> dentry) but changed inode on the server.
> 
> Is this a likely scenario?

Consider something like a git pull on the server, or a distributed
compile across many NFS clients. In both those cases, you are typically
creating and re-creating files with the same name while bypassing the
dcache on your client.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2012-03-06 17:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 12:56 [PATCH 0/9] vfs: path lookup fixes and cleanups Miklos Szeredi
2012-03-06 12:56 ` [PATCH 1/9] vfs: fix double put after complete_walk() Miklos Szeredi
2012-03-06 12:56 ` [PATCH 2/9] vfs: fix return value from do_last() Miklos Szeredi
2012-03-06 12:56 ` [PATCH 3/9] vfs: fix d_need_lookup/d_revalidate order in do_lookup Miklos Szeredi
2012-03-06 12:56 ` [PATCH 4/9] vfs: don't revalidate just looked up dentry Miklos Szeredi
2012-03-06 12:56 ` [PATCH 5/9] vfs: move MAY_EXEC check from __lookup_hash() Miklos Szeredi
2012-03-06 12:56 ` [PATCH 6/9] vfs: set LOOKUP_JUMPED in follow_managed Miklos Szeredi
2012-03-06 12:56 ` [PATCH 7/9] vfs: reorganize do_lookup Miklos Szeredi
2012-03-13  9:34   ` Christoph Hellwig
2012-03-13 11:04     ` Miklos Szeredi
2012-03-06 12:56 ` [PATCH 8/9] vfs: split __lookup_hash Miklos Szeredi
2012-03-20 16:39   ` Christoph Hellwig
2012-03-26 10:44     ` Miklos Szeredi
2012-03-06 12:56 ` [PATCH 9/9] nfs: don't open in ->d_revalidate Miklos Szeredi
2012-03-06 14:12   ` Myklebust, Trond
2012-03-06 16:26     ` Miklos Szeredi
2012-03-06 16:41       ` Myklebust, Trond
2012-03-06 17:10         ` Miklos Szeredi
2012-03-06 17:47           ` Myklebust, Trond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331056067.10560.26.camel@lade.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®