From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932330Ab2CFSRY (ORCPT ); Tue, 6 Mar 2012 13:17:24 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:60223 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757403Ab2CFSRV (ORCPT ); Tue, 6 Mar 2012 13:17:21 -0500 Message-ID: <1331057839.2140.12.camel@joe2Laptop> Subject: Re: [RFC PATCH] checkpatch: Warn on use of yield() From: Joe Perches To: Peter Zijlstra Cc: Andrew Morton , Mel Gorman , Miao Xie , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Theodore Ts'o" Date: Tue, 06 Mar 2012 10:17:19 -0800 In-Reply-To: <1331056859.2140.7.camel@joe2Laptop> References: <20120302112358.GA3481@suse.de> <1330723262.11248.233.camel@twins> <20120305121804.3b4daed4.akpm@linux-foundation.org> <1330999280.10358.3.camel@joe2Laptop> <1331037942.11248.307.camel@twins> <1331055666.2140.3.camel@joe2Laptop> <1331056466.11248.327.camel@twins> <1331056859.2140.7.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-03-06 at 10:00 -0800, Joe Perches wrote: > On Tue, 2012-03-06 at 18:54 +0100, Peter Zijlstra wrote: > > On Tue, 2012-03-06 at 09:41 -0800, Joe Perches wrote: > > > Perhaps the kernel-doc comments in sched/core.c > > > should/could be expanded/updated. > > Something like this? [] > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c [] > > @@ -4577,8 +4577,24 @@ EXPORT_SYMBOL(__cond_resched_softirq); > > /** > > * yield - yield the current processor to other threads. Perhaps the phrase "other threads" is poor word choice. Maybe: yield - yield the current processor to a runnable thread (might be the current thread)