From: Venkatesh Pallipadi <venki@google.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>, Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Aaron Durbin <adurbin@google.com>, Paul Turner <pjt@google.com>,
Yong Zhang <yong.zhang0@gmail.com>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Venkatesh Pallipadi <venki@google.com>
Subject: [PATCH 2/5] ia64: Use common fork_idle_from_wq in smpboot
Date: Tue, 6 Mar 2012 13:41:11 -0800 [thread overview]
Message-ID: <1331070074-31717-3-git-send-email-venki@google.com> (raw)
In-Reply-To: <1331070074-31717-1-git-send-email-venki@google.com>
Cleanup. Instead of reimplementing fork_idle on wq and idle task caching,
use fork_idle_from_wq().
Signed-off-by: Venkatesh Pallipadi <venki@google.com>
---
arch/ia64/kernel/smpboot.c | 49 +++----------------------------------------
1 files changed, 4 insertions(+), 45 deletions(-)
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index 5590979..b9026fa 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b/arch/ia64/kernel/smpboot.c
@@ -95,13 +95,8 @@ struct sal_to_os_boot *sal_state_for_booting_cpu = &sal_boot_rendez_state[0];
#define set_brendez_area(x) (sal_state_for_booting_cpu = &sal_boot_rendez_state[(x)]);
-#define get_idle_for_cpu(x) (idle_thread_array[(x)])
-#define set_idle_for_cpu(x,p) (idle_thread_array[(x)] = (p))
-
#else
-#define get_idle_for_cpu(x) (NULL)
-#define set_idle_for_cpu(x,p)
#define set_brendez_area(x)
#endif
@@ -481,53 +476,17 @@ struct pt_regs * __cpuinit idle_regs(struct pt_regs *regs)
return NULL;
}
-struct create_idle {
- struct work_struct work;
- struct task_struct *idle;
- struct completion done;
- int cpu;
-};
-
-void __cpuinit
-do_fork_idle(struct work_struct *work)
-{
- struct create_idle *c_idle =
- container_of(work, struct create_idle, work);
-
- c_idle->idle = fork_idle(c_idle->cpu);
- complete(&c_idle->done);
-}
-
static int __cpuinit
do_boot_cpu (int sapicid, int cpu)
{
int timeout;
- struct create_idle c_idle = {
- .work = __WORK_INITIALIZER(c_idle.work, do_fork_idle),
- .cpu = cpu,
- .done = COMPLETION_INITIALIZER(c_idle.done),
- };
-
- /*
- * We can't use kernel_thread since we must avoid to
- * reschedule the child.
- */
- c_idle.idle = get_idle_for_cpu(cpu);
- if (c_idle.idle) {
- init_idle(c_idle.idle, cpu);
- goto do_rest;
- }
-
- schedule_work(&c_idle.work);
- wait_for_completion(&c_idle.done);
+ struct task_struct *idle;
- if (IS_ERR(c_idle.idle))
+ idle = fork_idle_from_wq(cpu);
+ if (IS_ERR(idle))
panic("failed fork for CPU %d", cpu);
- set_idle_for_cpu(cpu, c_idle.idle);
-
-do_rest:
- task_for_booting_cpu = c_idle.idle;
+ task_for_booting_cpu = idle;
Dprintk("Sending wakeup vector %lu to AP 0x%x/0x%x.\n", ap_wakeup_vector, cpu, sapicid);
--
1.7.7.3
next prev parent reply other threads:[~2012-03-06 21:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 0:36 [PATCH] Extend mwait idle to optimize away CAL and RES interrupts to an idle CPU -v1 Venkatesh Pallipadi
2012-02-23 7:50 ` Ingo Molnar
2012-02-23 9:08 ` Peter Zijlstra
2012-02-23 20:04 ` Venki Pallipadi
2012-02-23 20:03 ` Venki Pallipadi
2012-03-02 0:33 ` Venki Pallipadi
2012-03-02 1:28 ` Suresh Siddha
2012-03-02 1:35 ` Venki Pallipadi
2012-03-02 1:37 ` Suresh Siddha
2012-03-02 2:00 ` Venki Pallipadi
2012-03-02 7:21 ` Ingo Molnar
2012-03-02 17:41 ` Suresh Siddha
2012-03-06 21:41 ` fork_idle from wq cleanup Venkatesh Pallipadi
2012-03-06 21:41 ` [PATCH 1/5] x86: Move fork_idle from wq and idle caching to common code Venkatesh Pallipadi
2012-03-06 21:41 ` Venkatesh Pallipadi [this message]
2012-03-06 21:41 ` [PATCH 3/5] mips: Use common fork_idle_from_wq in smpboot Venkatesh Pallipadi
2012-03-06 22:51 ` Ralf Baechle
2012-03-06 21:41 ` [PATCH 4/5] powerpc: " Venkatesh Pallipadi
2012-03-06 21:41 ` [PATCH 5/5] s390: " Venkatesh Pallipadi
2012-03-07 7:00 ` Heiko Carstens
2012-03-07 6:06 ` fork_idle from wq cleanup Suresh Siddha
2012-02-23 9:30 ` [PATCH] Extend mwait idle to optimize away CAL and RES interrupts to an idle CPU -v1 Peter Zijlstra
2012-02-23 19:34 ` Venki Pallipadi
2012-02-24 5:41 ` Yong Zhang
2012-02-24 6:13 ` Yong Zhang
2012-02-27 8:38 ` Peter Zijlstra
2012-02-27 9:08 ` Yong Zhang
2012-02-27 9:30 ` Peter Zijlstra
2012-02-27 9:51 ` Yong Zhang
2012-02-26 1:32 ` Paul E. McKenney
2012-02-27 9:06 ` Yong Zhang
2012-02-27 17:05 ` Paul E. McKenney
2012-02-28 7:12 ` Yong Zhang
2012-02-28 13:05 ` Paul E. McKenney
2012-02-29 6:36 ` Yong Zhang
2012-02-27 8:45 ` Peter Zijlstra
2012-02-27 18:17 ` Venki Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331070074-31717-3-git-send-email-venki@google.com \
--to=venki@google.com \
--cc=adurbin@google.com \
--cc=benh@kernel.crashing.org \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome