From: Peter Zijlstra <peterz@infradead.org>
To: Don Zickus <dzickus@redhat.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Li Zhong <zhong@linux.vnet.ibm.com>
Subject: Re: [PATCH] x86,nmi: Fix page faults by nmiaction if kmemcheck is enabled
Date: Thu, 08 Mar 2012 20:42:46 +0100 [thread overview]
Message-ID: <1331235766.11248.404.camel@twins> (raw)
In-Reply-To: <1331234231-18914-1-git-send-email-dzickus@redhat.com>
On Thu, 2012-03-08 at 14:17 -0500, Don Zickus wrote:
> +int __register_nmi_handler(unsigned int type, unsigned int nmiflags,
> + struct nmiaction *na)
> {
> + if (!na->handler)
> return -EINVAL;
>
> + na->flags = nmiflags;
>
> + return __setup_nmi(type, na);
> }
> +EXPORT_SYMBOL_GPL(__register_nmi_handler);
Put the na->flags thing in the CPP bit, put the !handler check in
__setup_nmi() and loose the pointless wrappery?
> void unregister_nmi_handler(unsigned int type, const char *name)
> {
> + __free_nmi(type, name);
> }
>
> EXPORT_SYMBOL_GPL(unregister_nmi_handler);
That's another quite pointless wrapper there..
prev parent reply other threads:[~2012-03-08 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 19:17 Don Zickus
2012-03-08 19:42 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331235766.11248.404.camel@twins \
--to=peterz@infradead.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®