mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: cmetcalf@tilera.com, torvalds@linux-foundation.org
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Edac Mailing List <linux-edac@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stable@kernel.org
Subject: [PATCH] tile: remove a non-existing header
Date: Mon, 12 Mar 2012 11:18:50 -0300	[thread overview]
Message-ID: <1331561930-14964-1-git-send-email-mchehab@redhat.com> (raw)

While testing some API changes at the EDAC core, I've tested the EDAC
drivers compilation on all supported architectures, including Tilera.

I noticed that Tilera upstream code has issues: it doesn't compile with
kernel 3.2:

In file included from include/linux/linkage.h:5,
                 from include/linux/kernel.h:13,
                 from include/linux/sched.h:55,
                 from arch/tile/kernel/asm-offsets.c:19:
/home/mchehab/redhat/trees/work/new_edac/arch/tile/include/asm/linkage.h:18:22: error: feedback.h: No such file or directory
make[1]: *** [arch/tile/kernel/asm-offsets.s] Error 1

Without it, it is not possible to compile anything on this archictecture
using this default configuration:
	./arch/tile/configs/tilegx_defconfig

Cc: stable@kernel.org
Signed-of-by: Mauro Carvalho Chehab <mchehab@redhat.com>

---

Btw, the ./arch/tile/configs/tilepro_defconfig doesn't compile even
with this fix. It fails at arch/tile/include/asm/atomic_64.h because
atomic64_t is never defined, but it is used there and on other places.

Also, while the edac_tile driver seems to be for both Tile GX and Tilepro
sub-archs, it is not included on tilegx_defconfig. It would make sense
to add it there, in order to make easier for people to test/use the
EDAC drivers.

---
 arch/tile/include/asm/linkage.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/tile/include/asm/linkage.h b/arch/tile/include/asm/linkage.h
index e121c39..43b298e 100644
--- a/arch/tile/include/asm/linkage.h
+++ b/arch/tile/include/asm/linkage.h
@@ -15,8 +15,6 @@
 #ifndef _ASM_TILE_LINKAGE_H
 #define _ASM_TILE_LINKAGE_H
 
-#include <feedback.h>
-
 #define __ALIGN .align 8
 
 /*
-- 
1.7.8


             reply	other threads:[~2012-03-12 14:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 14:18 Mauro Carvalho Chehab [this message]
2012-03-12 14:31 ` Chris Metcalf
2012-03-12 15:00   ` Mauro Carvalho Chehab
2012-03-12 15:04     ` Chris Metcalf
2012-03-12 18:18     ` Chris Metcalf
2012-03-13 13:28       ` Mauro Carvalho Chehab
2012-03-14 19:07 ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331561930-14964-1-git-send-email-mchehab@redhat.com \
    --to=mchehab@redhat.com \
    --cc=cmetcalf@tilera.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®