From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung.kim@lge.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] perf report: Treat an argument as a symbol filter
Date: Tue, 13 Mar 2012 14:40:21 +0100 [thread overview]
Message-ID: <1331646021.18960.71.camel@twins> (raw)
In-Reply-To: <20120313062105.GB24357@elte.hu>
On Tue, 2012-03-13 at 07:21 +0100, Ingo Molnar wrote:
> To play the devil's advocate it uses up valuable perf report
> command line real estate and we probably cannot change this
> workflow in the future, once people get used to it.
I would indeed suggest to make it a proper argument and add argument
parsing to report like we have for all the other commands.
Say something like: perf report --symbol-filter="foobar"
and maybe an appropriate short version.
next prev parent reply other threads:[~2012-03-13 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 6:14 [PATCH 1/4] perf hists: Add hists__filter_by_symbol Namhyung Kim
2012-03-13 6:14 ` [PATCH 2/4] perf ui browser: Introduce ui_browser__input_window Namhyung Kim
2012-03-13 6:14 ` [PATCH 3/4] perf ui browser: Add 's' key to filter by symbol name Namhyung Kim
2012-03-13 6:14 ` [PATCH 4/4] perf report: Treat an argument as a symbol filter Namhyung Kim
2012-03-13 6:21 ` Ingo Molnar
2012-03-13 13:40 ` Peter Zijlstra [this message]
2012-03-13 15:24 ` Ingo Molnar
2012-03-15 0:39 ` [PATCH] perf report: Add --symbol-filter option Namhyung Kim
2012-03-15 17:34 ` [PATCH 1/4] perf hists: Add hists__filter_by_symbol Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331646021.18960.71.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®