mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Daniel J Blueman <daniel@numascale-asia.com>,
	Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Steffen Persvold <sp@numascale.com>
Subject: Re: x2APIC and many-APIC systems...
Date: Tue, 13 Mar 2012 16:16:29 -0700	[thread overview]
Message-ID: <1331680589.18900.76.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <CAE9FiQWtHD41qoYSm+tzLROUyR_33bwyBgE882cop3vbEmSPhw@mail.gmail.com>

On Tue, 2012-03-13 at 15:58 -0700, Yinghai Lu wrote:
> On Tue, Mar 13, 2012 at 2:29 AM, Daniel J Blueman
> <daniel@numascale-asia.com> wrote:
> > Ingo, Suresh,
> >
> > Commit a35fd28256e7736cc84af8931a16224f0bfaaf6c prevents x2APIC structures
> > being used from the ACPI MADT if the cores don't advertise the x2APIC
> > feature. Commit c284b42abadbb22083bfde24d308899c08d44ffa prevents onlining
> > cores with APIC ID >255 in non-x2APIC mode. Since NumaChip/NumaConnect uses
> > x2APIC structures to describe non-x2APIC systems (AMD Opteron) with lots of
> > APICs, we thus now can't boot all the cores.
> >
> > We are able to set the x2APIC bit in the processor feature flags, so get
> > caught by the second patch. Is there an appropriate approach to use in these
> > circumstances? Otherwise, would a patch that separates the APIC ID handover
> > and future x2APIC MSR access be appropriate?
> >
> 
> add is_apicid_valid() in struct apic?

Yes, we can generalize that and move into the apicdriver. Daniel, will
you be able to prepare such a patch?

thanks,
suresh


  reply	other threads:[~2012-03-13 23:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  9:29 Daniel J Blueman
2012-03-13 22:58 ` Yinghai Lu
2012-03-13 23:16   ` Suresh Siddha [this message]
2012-03-14  7:17     ` [PATCH] Move APIC ID validity check into platform APIC code Daniel J Blueman
2012-03-14 11:27       ` [tip:x86/platform] x86/platform: " tip-bot for Daniel J Blueman
2012-03-14 17:58       ` [PATCH] " Yinghai Lu
2012-03-14 20:18         ` Steffen Persvold
2012-03-14 23:19           ` Yinghai Lu
2012-03-15 18:03             ` [PATCH] Use x2apic_supported() in the default_apic_id_valid() function Steffen Persvold
2012-03-15 20:23               ` Yinghai Lu
2012-03-15 21:21                 ` Suresh Siddha
2012-03-15 22:34                   ` Steffen Persvold
2012-03-15 22:58                     ` Steffen Persvold
2012-03-15 23:04                     ` Suresh Siddha
2012-03-15 23:17                       ` Steffen Persvold
2012-03-15 23:33                       ` Steffen Persvold
2012-03-15 23:44                         ` Steffen Persvold
2012-03-16  0:07                       ` [PATCH] Added separate apic_id_valid() functions for selected apic drivers Steffen Persvold
2012-03-16  0:13                         ` Suresh Siddha
2012-03-16  0:57                           ` Yinghai Lu
2012-03-16  6:45                           ` Steffen Persvold
2012-03-16  2:08                   ` [PATCH] Use x2apic_supported() in the default_apic_id_valid() function Yinghai Lu
2012-03-16  3:03                     ` Yinghai Lu
2012-03-16  4:19                     ` Yinghai Lu
2012-03-16  6:56                       ` Steffen Persvold
2012-03-16 16:57                         ` Yinghai Lu
2012-03-16 18:01                           ` Suresh Siddha
2012-03-16 19:10                             ` Yinghai Lu
2012-03-16 19:25                               ` [PATCH REPOST] Added separate apic_id_valid() functions for selected apic drivers Steffen Persvold
2012-03-20 10:41                                 ` Steffen Persvold
2012-03-20 10:49                                   ` Ingo Molnar
2012-03-23 19:45                                 ` [tip:x86/urgent] x86/apic: Add " tip-bot for Steffen Persvold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331680589.18900.76.camel@sbsiddha-desk.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=daniel@numascale-asia.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sp@numascale.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®