From: Jesse Gross <jesse@nicira.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Pravin B Shelar <pshelar@nicira.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Justin Pettit <jpettit@nicira.com>
Subject: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().
Date: Tue, 13 Mar 2012 19:08:17 -0700 [thread overview]
Message-ID: <1331690897-26496-1-git-send-email-jesse@nicira.com> (raw)
From: Pravin B Shelar <pshelar@nicira.com>
Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
cleanup path i.e. `ip netns delete `.
This issue exists back to 3.0.
CC: Eric W. Biederman <ebiederm@xmission.com>
Reported-by: Justin Pettit <jpettit@nicira.com>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
fs/proc/namespaces.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c
index 27da860..3551f1f 100644
--- a/fs/proc/namespaces.c
+++ b/fs/proc/namespaces.c
@@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
ei->ns_ops = ns_ops;
ei->ns = ns;
- dentry->d_op = &pid_dentry_operations;
+ d_set_d_op(dentry, &pid_dentry_operations);
d_add(dentry, inode);
/* Close the race of the process dying before we return the dentry */
if (pid_revalidate(dentry, NULL))
--
1.7.5.4
next reply other threads:[~2012-03-14 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 2:08 Jesse Gross [this message]
2012-03-14 18:43 ` Eric W. Biederman
2012-03-16 20:34 ` Jesse Gross
2012-03-22 23:17 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2012-02-23 4:05 Pravin B Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331690897-26496-1-git-send-email-jesse@nicira.com \
--to=jesse@nicira.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jpettit@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®