mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 0/2] block: align start sector of a discard request
Date: Wed, 14 Mar 2012 18:12:26 +0100	[thread overview]
Message-ID: <1331745148-24885-1-git-send-email-pbonzini@redhat.com> (raw)

When a disk has a large discard_granularity, discards are not split with
optimal alignment; the pessimization gets bigger as discard_granularity
and max_discard_sectors become closer.

Take the limit case of discard_granularity == max_discard_sectors == 64.
Then, if a request is submitted for 256 sectors 2..257 it will be split
like this: 2..65, 66..129, 130..193, 194..257.  None of these requests
is aligned, so in fact you might end up with no discarded logical blocks
at all.  With this patch, the split will be 2..63, 64..127, 128..191,
192..255, 256..257.  The patches also take the discard_alignment into
consideration.

Patch 1 adjusts the computation of the granularity-adjusted
max_discard_sectors so that it prepares for the new code in patch 2,
while patch 2 actually adjusts the split.

Paolo Bonzini (2):
  block: tweak rounding of max_discard_sectors
  block: split discard into aligned requests

 block/blk-lib.c    |   41 +++++++++++++++++++++++++++--------------
 1 files changed, 27 insertions(+), 14 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-03-14 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 17:12 Paolo Bonzini [this message]
2012-03-14 17:12 ` [PATCH 1/2] block: tweak rounding of max_discard_sectors Paolo Bonzini
2012-03-27  9:04   ` Christoph Hellwig
2012-03-14 17:12 ` [PATCH 2/2] block: split discard into aligned requests Paolo Bonzini
2012-03-27  9:06   ` Christoph Hellwig
2012-03-21 21:48 ` [PATCH 0/2] block: align start sector of a discard request Paolo Bonzini
2012-03-27  6:43 ` Paolo Bonzini
2012-03-27  6:54   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331745148-24885-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®