From: jim.cromie@gmail.com
To: jbaron@redhat.com, rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org, Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 11/11] dynamic_debug: init with core_initcall, not arch_initcall
Date: Wed, 14 Mar 2012 17:02:06 -0600 [thread overview]
Message-ID: <1331766126-11674-12-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1331766126-11674-1-git-send-email-jim.cromie@gmail.com>
From: Jim Cromie <jim.cromie@gmail.com>
Initializing dynamic_debug earlier makes pr_debug useful earlier
in boot process. For example:
dyndbg=" module params +p"
will enable parameter processing for initcall levels after core.
Note that this is too late to enable params processing for builtin
modules, which is a significant limitation, but its still
potentially useful.
RFC: This works for me on a 64 bit desktop and i586 SBC, but is
untested on other arches. I presume there is or was a reason
it was done with arch_initcall, maybe the constraints have changed.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8fcead5..747245d 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1009,7 +1009,7 @@ out_free:
return 0;
}
/* Allow early initialization for boot messages via boot param */
-arch_initcall(dynamic_debug_init);
+core_initcall(dynamic_debug_init);
/* Debugfs setup must be done later */
module_init(dynamic_debug_init_debugfs);
--
1.7.7.6
next prev parent reply other threads:[~2012-03-14 23:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 23:01 [00/11] pr_debug during module initialization jim.cromie
2012-03-14 23:01 ` [PATCH 01/11] init: trivial tweaks to initcall_levels jim.cromie
2012-03-14 23:01 ` [PATCH 02/11] dynamic_debug: fix leading spaces jim.cromie
2012-03-14 23:01 ` [PATCH 03/11] dynamic_debug: replace if (verbose) pr_info with macro vpr_info jim.cromie
2012-03-14 23:01 ` [PATCH 04/11] dynamic_debug: change ddebug_query core param to dyndbg jim.cromie
2012-03-14 23:02 ` [PATCH 05/11] params: add param-name to parse_one's pr_debug() jim.cromie
2012-03-14 23:02 ` [PATCH 06/11] params: add 3rd arg to option handler callback signature jim.cromie
2012-03-14 23:02 ` [PATCH 07/11] dynamic_debug: make dynamic-debug work during module initialization jim.cromie
2012-03-14 23:02 ` [PATCH 08/11] pnp: if CONFIG_DYNAMIC_DEBUG, use pnp.dyndbg instead of pnp.debug jim.cromie
2012-03-14 23:02 ` [PATCH 09/11] dynamic_debug: add modname arg to exec_query callchain jim.cromie
2012-03-14 23:02 ` [PATCH 10/11] dynamic_debug: update Documentation/*, Kconfig.debug jim.cromie
2012-03-14 23:02 ` jim.cromie [this message]
2012-03-19 2:04 ` [00/11] pr_debug during module initialization Rusty Russell
2012-03-19 6:17 ` Jim Cromie
2012-03-19 23:27 ` Rusty Russell
2012-03-23 20:27 ` Jason Baron
2012-03-24 0:12 ` Jim Cromie
2012-03-26 0:24 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331766126-11674-12-git-send-email-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®