From: Peter Zijlstra <peterz@infradead.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yanmin Zhang <yanmin_zhang@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: RE: [PATCH] Fix the race between smp_call_function and CPU booting
Date: Thu, 15 Mar 2012 11:46:31 +0100 [thread overview]
Message-ID: <1331808391.18960.160.camel@twins> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A056F47@SHSMSX101.ccr.corp.intel.com>
On Thu, 2012-03-15 at 00:11 +0000, Liu, Chuansheng wrote:
>
> > -----Original Message-----
> > From: Peter Zijlstra [mailto:peterz@infradead.org]
> > Sent: Wednesday, March 14, 2012 5:43 PM
> > To: Liu, Chuansheng
> > Cc: linux-kernel@vger.kernel.org; Yanmin Zhang; tglx@linutronix.de
> > Subject: RE: [PATCH] Fix the race between smp_call_function and CPU booting
> >
> > On Wed, 2012-03-14 at 06:27 +0000, Liu, Chuansheng wrote:
> > > On the unplug case, after set the CPU to !active, we do not need IPI
> > > handling for the corresponding CPU before it is set to offline. I did
> > > not find any impact that limiting the smp_call_function just after CPU
> > > is active.
> >
> > Have a look at Alpha, it's flush_tlb_mm() can use smp_call_function(), in
> > the !active,online case you very much still need to tlb flush that cpu.
> >
> > The fact that it works on a limited use case on x86 doesn't say anything much
> > at all.
> Thanks your pointing out, do you have any other perfect solution for this issue?
> As for the stress test result, advancing the setting active before setting online broken
> something either.
I'm not sure I understand.. are you saying that commit
5fbd036b552f633abb394a319f7c62a5c86a9cd7 in tip/master broke something?
next prev parent reply other threads:[~2012-03-15 10:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 9:27 Liu, Chuansheng
2012-03-12 9:32 ` Peter Zijlstra
2012-03-13 6:43 ` Liu, Chuansheng
2012-03-12 9:58 ` Peter Zijlstra
2012-03-13 6:46 ` Liu, Chuansheng
2012-03-13 15:57 ` Peter Zijlstra
2012-03-14 6:27 ` Liu, Chuansheng
2012-03-14 9:43 ` Peter Zijlstra
2012-03-15 0:11 ` Liu, Chuansheng
2012-03-15 10:46 ` Peter Zijlstra [this message]
2012-03-16 6:24 ` Liu, Chuansheng
2012-03-16 9:49 ` Peter Zijlstra
2012-03-19 0:58 ` Liu, Chuansheng
2012-03-19 10:03 ` Peter Zijlstra
2012-03-20 0:22 ` Liu, Chuansheng
2012-03-20 12:17 ` Peter Zijlstra
2012-03-20 13:14 ` Srivatsa S. Bhat
2012-03-20 13:41 ` Peter Zijlstra
2012-03-20 15:02 ` Srivatsa S. Bhat
2012-03-21 5:59 ` Liu, Chuansheng
2012-03-21 9:12 ` Peter Zijlstra
2012-03-21 12:25 ` Peter Zijlstra
2012-03-22 0:59 ` Liu, Chuansheng
2012-03-23 10:25 ` Peter Zijlstra
2012-03-23 11:32 ` Liu, Chuansheng
2012-03-23 12:02 ` Peter Zijlstra
2012-03-23 12:06 ` Liu, Chuansheng
2012-03-23 12:13 ` Peter Zijlstra
2012-03-23 12:21 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331808391.18960.160.camel@twins \
--to=peterz@infradead.org \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®