From: Matt Fleming <matt.fleming@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Maarten Lankhorst <m.b.lankhorst@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] x86, efi: fix pointer math issue in handle_ramdisks()
Date: Fri, 16 Mar 2012 15:20:04 +0000 [thread overview]
Message-ID: <1331911204.4041.13.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20120305180614.GA26880@elgon.mountain>
On Mon, 2012-03-05 at 21:06 +0300, Dan Carpenter wrote:
> "filename" is a efi_char16_t string so this check for reaching the end
> of the array doesn't work. We need to cast the pointer to (u8 *) before
> doing the math.
>
> This patch changes the "filename" to "filename_16" to avoid confusion in
> the future.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Rename "filename" to "filename_16"
> Also changed cast from (char *) to (u8 *) because it's not a C
> character string. Ingo suggested (void *) but that's a GCCism
> I think.
Looks good to me. Is someone going to pick this up?
next prev parent reply other threads:[~2012-03-16 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 19:01 [patch] " Dan Carpenter
2012-03-03 7:54 ` Ingo Molnar
2012-03-05 18:06 ` [patch v2] " Dan Carpenter
2012-03-05 18:42 ` walter harms
2012-03-05 19:33 ` H. Peter Anvin
2012-03-06 8:44 ` walter harms
2012-03-16 19:55 ` H. Peter Anvin
2012-03-18 14:33 ` walter harms
2012-03-16 15:20 ` Matt Fleming [this message]
2012-03-16 21:27 ` [tip:x86/urgent] x86, efi: Fix " tip-bot for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331911204.4041.13.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.b.lankhorst@gmail.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®