From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99BA72253B5; Thu, 15 May 2025 12:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747311967; cv=none; b=rqjJDmWQRE6rBn1heHxw0VSrKl0E0hqjRwH3QWUfhcWg7EPGuTSX9lxvRv9r9UOelp5ZVO61c1CftfTncosiY45lfxOlJ0bjx4GX+ZILL1wW7+kQPx8MJUAb5xQHQIuseQN6tK9R4w9sL33q608aCsDZgFXpWvU4RMVlgSE2AKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747311967; c=relaxed/simple; bh=Iog2cRfHxHa+pMwdvFWF7wxdSAoncdjpR3FuqSX7GI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rZa1uJMCjZ08eCdx3aFb0ecee8wN6oNByavFq9CiL4wbxl8JauzyqKQgGOVqE2EbGv8oLlZYhAHOjMu8/ap4A84PjqFYm/uu2TaZrZ61MUfdCXdmQDSEQNvoOiS8Ge4vjO9MRUELBl95ftdlzK4NUdektd/wrsPVKBHrSLpL/RQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=OrvSOqGh; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="OrvSOqGh" Received: from [10.6.0.9] (host-88-217-226-44.customer.m-online.net [88.217.226.44]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id 25DD92FC0050; Thu, 15 May 2025 14:26:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1747311961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1sP88w0pAXyrCUGuXhTZVPahydXQvuJqatLY9v+m+Y=; b=OrvSOqGhX6R1aug+jIxNnIiABZ9482X5aAC17LC9uBEwnuYm2E2+pHsOTD34rAcyUAhIiz EJvRmU/hNf2Ak440WXmRoYikNIM2qTo4AZ1fJhb1XqW2LF/3vtbFyLkiSi+L7XFU4RQqAx apOuC2sTH+nIkkqVsmfn0R1SE8Q95AA= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: <1331ddc4-fb74-4985-a309-87fd97d0583b@tuxedocomputers.com> Date: Thu, 15 May 2025 14:26:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13 - F24 To: Hans de Goede , Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311180643.1107430-1-wse@tuxedocomputers.com> <20250311180643.1107430-2-wse@tuxedocomputers.com> <76c57b22-04d3-4331-a10c-b210db5f9055@redhat.com> <9da24c58-25ab-4b21-b0ed-f777970affe7@tuxedocomputers.com> Content-Language: en-US From: Werner Sembach In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Am 17.03.25 um 23:23 schrieb Hans de Goede: > Hi Werner, > > On 17-Mar-25 6:00 PM, Werner Sembach wrote: >> Hi, >> >> Am 17.03.25 um 12:58 schrieb Hans de Goede: >>> Hi Werner, >>> >>> On 11-Mar-25 19:06, Werner Sembach wrote: >>>> Currently only F23 is correctly mapped for PS/2 keyboards. >>>> >>>> Following to this table: >>>> https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf >>> That is a very interesting document, good find! >>> >>>> - F24 and Zenkaku/Hankaku share the same scancode, but since in real world >>>> Zenkaku/Hankaku keys seem to just use the tilde scancode, this patch binds the >>>> scancode to F24. Note that on userspace side the KEY_ZENKAKUHANKAKU keycode is >>>> currently not bound in xkeyboard-config, so it is (mostly*) unused anyway. >>>> >>>> * Qt on Wayland and therefore KDE on Wayland can see the keypress anyway for >>>> some reason and it is actually used in a touchpad toggle shortcut, but this is >>>> currently being fixed in both KDE and xkeyboard-config to make this less weird, >>>> so it could directly be fixed to correctly handle the F24 keypress instead. >>>> >>>> - The scancodes for F13-F22 are currently unmapped so there will probably be no >>>> harm in mapping them. This would also fix the issue that some of these keys >>>> can't be mapped as the target from userspace using the `setkeycodes` command. >>>> >>>> Signed-off-by: Werner Sembach >>> Thanks, patch looks good to me: >>> >>> Reviewed-by: Hans de Goede >> Thanks for reviewing. >> >> Should I resend the patch standalone because the first of this Patchset will likely be rejected? > I think this one will apply cleanly without applying patch 1/2 > first, so no reason for a resend / v3 AFAICT. > > Let's wait and see what feedback Dmitry have once he can make > some time to take a look at this. Hope a gentle bump is ok by now? Best regards, Werner > > Regards, > > Hans > > > > >>>> --- >>>>   drivers/input/keyboard/atkbd.c | 12 ++++++------ >>>>   1 file changed, 6 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c >>>> index 3598a21d9d014..4bd6e6ef0715e 100644 >>>> --- a/drivers/input/keyboard/atkbd.c >>>> +++ b/drivers/input/keyboard/atkbd.c >>>> @@ -84,12 +84,12 @@ static const unsigned short atkbd_set2_keycode[ATKBD_KEYMAP_SIZE] = { >>>>   #include "hpps2atkbd.h"    /* include the keyboard scancodes */ >>>>     #else >>>> -      0, 67, 65, 63, 61, 59, 60, 88,  0, 68, 66, 64, 62, 15, 41,117, >>>> -      0, 56, 42, 93, 29, 16,  2,  0,  0,  0, 44, 31, 30, 17,  3,  0, >>>> -      0, 46, 45, 32, 18,  5,  4, 95,  0, 57, 47, 33, 20, 19,  6,183, >>>> -      0, 49, 48, 35, 34, 21,  7,184,  0,  0, 50, 36, 22,  8,  9,185, >>>> -      0, 51, 37, 23, 24, 11, 10,  0,  0, 52, 53, 38, 39, 25, 12,  0, >>>> -      0, 89, 40,  0, 26, 13,  0,193, 58, 54, 28, 27,  0, 43,  0, 85, >>>> +      0, 67, 65, 63, 61, 59, 60, 88,183, 68, 66, 64, 62, 15, 41,117, >>>> +    184, 56, 42, 93, 29, 16,  2,  0,185,  0, 44, 31, 30, 17,  3,  0, >>>> +    186, 46, 45, 32, 18,  5,  4, 95,187, 57, 47, 33, 20, 19,  6,183, >>>> +    188, 49, 48, 35, 34, 21,  7,184,189,  0, 50, 36, 22,  8,  9,185, >>>> +    190, 51, 37, 23, 24, 11, 10,  0,191, 52, 53, 38, 39, 25, 12,  0, >>>> +    192, 89, 40,  0, 26, 13,  0,193, 58, 54, 28, 27,  0, 43,  0,194, >>>>         0, 86, 91, 90, 92,  0, 14, 94,  0, 79,124, 75, 71,121,  0,  0, >>>>        82, 83, 80, 76, 77, 72,  1, 69, 87, 78, 81, 74, 55, 73, 70, 99, >>>>