From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756732Ab2CTDC5 (ORCPT ); Mon, 19 Mar 2012 23:02:57 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:36969 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754680Ab2CTDC4 (ORCPT ); Mon, 19 Mar 2012 23:02:56 -0400 Message-ID: <1332212574.7847.49.camel@joe2Laptop> Subject: Re: [PATCH 2/9] ext4: Use pr_fmt and pr_ From: Joe Perches To: "Ted Ts'o" Cc: David Miller , anca.emanuel@gmail.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 19 Mar 2012 20:02:54 -0700 In-Reply-To: <20120320025835.GE14363@thunk.org> References: <20120319153133.GA2502@thunk.org> <20120319161425.GB2502@thunk.org> <20120319.141402.934377752041508724.davem@davemloft.net> <20120319183126.GA6031@thunk.org> <1332182773.3908.11.camel@joe2Laptop> <20120320010401.GA14363@thunk.org> <1332207202.7847.23.camel@joe2Laptop> <20120320014707.GD14363@thunk.org> <1332208741.7847.46.camel@joe2Laptop> <20120320025835.GE14363@thunk.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-03-19 at 22:58 -0400, Ted Ts'o wrote: [good stuff] > Of course, the body of the message needs to be standardized too. But > that's orthogonal to the problem of passing the kernel structure which > identifies the object which the log message is about. That part is > completely and utterly necessary if you're going to standardize the > *first* part of the printable dmesg log, which contains the structured > information. All of what you say is true, but you're neglecting the ability to scrape or notify a particular set of per subsystem messages that pr_ could easily provide that a bare printk could not.