mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Cc: lee.jones@linaro.org, linux-input@vger.kernel.org,
	pmeerw@pmeerw.net, jic23@kernel.org, knaack.h@gmx.de,
	lars@metafoo.de, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, harald@ccbib.org,
	fabio.estevam@freescale.com, linux-iio@vger.kernel.org,
	marex@denx.de
Subject: Re: [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen
Date: Mon, 30 Jan 2017 00:55:09 +0100 (CET)	[thread overview]
Message-ID: <1332233362.76422.1485734109212@email.1und1.de> (raw)
In-Reply-To: <d18975ff97a8855e9221b0a180b3664a0d04348c.1485711797.git.ksenija.stanojevic@gmail.com>

Hi Ksenija,

> Ksenija Stanojevic <ksenija.stanojevic@gmail.com> hat am 29. Januar 2017 um 19:04 geschrieben:
> 
> 
> Add 4-wire/5-wire touchscreen controller.

i compiled all 3 driver as a module and kept the devicetree for the Olinuxino iMX233 [1] as it is (no touchscreen). After booting all 3 driver are loaded:

Module                  Size  Used by
mxs_lradc_adc          11000  0
industrialio_triggered_buffer     2628  1 mxs_lradc_adc
kfifo_buf               3337  1 industrialio_triggered_buffer
mxs_lradc_ts            4192  0
mxs_lradc               4402  0
mfd_core                4612  1 mxs_lradc

But the touchscreen driver threw this error:

[  427.230000] mxs-lradc-ts: probe of mxs-lradc-ts failed with error -22

I didn't expect this behavior. I expect that the touchscreen driver notice that there isn't a touchscreen property and abort probing silently. Also i didn't expected that the driver is still loaded in case of a probe error.

Btw shouldn't be the mxs_lradc_adc "Used by" mxs_lradc?

Because "modprobe -r mxs_lradc" doesn't unload mxs_lradc_adc.

[1] - http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23-olinuxino.dts

  reply	other threads:[~2017-01-29 23:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-29 18:04 [PATCH v13 0/5] mxs-lradc: Split driver into MFD Ksenija Stanojevic
2017-01-29 18:04 ` [PATCH v13 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD Ksenija Stanojevic
2017-01-29 23:15   ` Stefan Wahren
2017-01-29 18:04 ` [PATCH v13 2/5] iio: adc: mxs-lradc: Add support for adc driver Ksenija Stanojevic
2017-01-29 23:35   ` Stefan Wahren
2017-01-29 18:04 ` [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen Ksenija Stanojevic
2017-01-29 23:55   ` Stefan Wahren [this message]
2017-01-29 18:04 ` [PATCH v13 4/5] iio: adc: mxs-lradc: Remove driver Ksenija Stanojevic
2017-01-29 18:04 ` [PATCH v13 5/5] mfd: Move binding document Ksenija Stanojevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332233362.76422.1485734109212@email.1und1.de \
    --to=stefan.wahren@i2se.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=harald@ccbib.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®