From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063Ab2CTJV5 (ORCPT ); Tue, 20 Mar 2012 05:21:57 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:43631 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752633Ab2CTJV4 (ORCPT ); Tue, 20 Mar 2012 05:21:56 -0400 Message-ID: <1332235315.7847.63.camel@joe2Laptop> Subject: Re: [PATCH 2/9] ext4: Use pr_fmt and pr_ From: Joe Perches To: Jiri Slaby Cc: Jiri Slaby , "Ted Ts'o" , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 20 Mar 2012 02:21:55 -0700 In-Reply-To: <4F684673.1050309@suse.cz> References: <20120319040950.GG31682@thunk.org> <1332131137.23125.44.camel@joe2Laptop> <4F6762F1.7050902@gmail.com> <1332176943.1983.28.camel@joe2Laptop> <4F684673.1050309@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-03-20 at 09:57 +0100, Jiri Slaby wrote: > On 03/19/2012 06:09 PM, Joe Perches wrote: > > As far as I can tell, your "reasons" as you > > explained it is that you just do not like > > whitespace or style changes. > No, sorry, you misunderstand me. No, sorry, you were simply unclear in your reference. > And BTW setting the argument that it is a newer interface (that is what > ath5k pr_* conversion patches commit log says) is not a good > justification at all. No again, the ath5k pr_ conversion patches are to standardize prefixes and to reduce code size by centralizing tests. https://lkml.org/lkml/2012/3/18/121 https://lkml.org/lkml/2012/3/18/123 https://lkml.org/lkml/2012/3/18/124 I happen to like 30K/10+% code size reductions.