mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@linux.intel.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros
Date: Wed, 21 Mar 2012 15:39:21 +0530	[thread overview]
Message-ID: <1332324561.19804.0.camel@vkoul-udesk3> (raw)
In-Reply-To: <1331209599-23802-1-git-send-email-fabio.estevam@freescale.com>

On Thu, 2012-03-08 at 09:26 -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied Thanks
> ---
>  drivers/dma/imx-sdma.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
>  	if (pdata) {
>  		ret = sdma_get_firmware(sdma, pdata->fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> +			dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
>  	} else {
>  		/*
>  		 * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
>  		ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
>  					      &fw_name);
>  		if (ret)
> -			dev_err(&pdev->dev, "failed to get firmware name\n");
> +			dev_warn(&pdev->dev, "failed to get firmware name\n");
>  		else {
>  			ret = sdma_get_firmware(sdma, fw_name);
>  			if (ret)
> -				dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> +				dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
>  		}
>  	}
>  


-- 
~Vinod


      parent reply	other threads:[~2012-03-21 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 12:26 Fabio Estevam
2012-03-13 13:13 ` Sascha Hauer
2012-03-21 10:09 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332324561.19804.0.camel@vkoul-udesk3 \
    --to=vinod.koul@linux.intel.com \
    --cc=fabio.estevam@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®