mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Petr Uzel <petr.uzel@suse.cz>
Cc: linux-kernel@vger.kernel.org, Willem Riede <osst@riede.org>,
	jack@suse.cz, linux-scsi@vger.kernel.org,
	juergen.gross@ts.fujitsu.com
Subject: Re: [PATCH] st: fix race in st_scsi_execute_end
Date: Wed, 21 Mar 2012 10:09:41 +0000	[thread overview]
Message-ID: <1332324581.2909.38.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20111021113108.GA26181@foxbat.suse.cz>

On Fri, 2011-10-21 at 13:31 +0200, Petr Uzel wrote:
> The call to complete() in st_scsi_execute_end() wakes up sleeping thread
> in write_behind_check(), which frees the st_request, thus invalidating
> the pointer to the associated bio structure, which is then passed to the
> blk_rq_unmap_user(). Fix by storing pointer to bio structure into
> temporary local variable.
> 
> This bug is present since at least linux-2.6.32.

This patch isn't applyable.  That's because gpg has mangled it.  You
either need to turn it off or do detached signatures.

Thanks,

James



      parent reply	other threads:[~2012-03-21 10:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 11:31 Petr Uzel
2011-10-21 17:00 ` Kai Makisara
2012-03-21 10:09 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332324581.2909.38.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jack@suse.cz \
    --cc=juergen.gross@ts.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osst@riede.org \
    --cc=petr.uzel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®