From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932962Ab2CZQcN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 26 Mar 2012 12:32:13 -0400
Received: from perches-mx.perches.com ([206.117.179.246]:55166 "EHLO
	labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S932561Ab2CZQcK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 26 Mar 2012 12:32:10 -0400
Message-ID: <1332779529.6160.96.camel@joe2Laptop>
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to
 do_sparc_fault
From: Joe Perches <joe@perches.com>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: davem@davemloft.net, Paul Gortmaker <paul.gortmaker@windriver.com>,
        Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 26 Mar 2012 09:32:09 -0700
In-Reply-To: <CAFPAmTSyYJkATAD32WqHZY_PdWGjitEq4vgqCZeqjo+V24dh3Q@mail.gmail.com>
References: <1332775946-2162-1-git-send-email-consul.kautuk@gmail.com>
	 <1332778595.6160.84.camel@joe2Laptop>
	 <CAFPAmTSyYJkATAD32WqHZY_PdWGjitEq4vgqCZeqjo+V24dh3Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.2- 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2012-03-26 at 12:20 -0400, Kautuk Consul wrote:
> > David meant that the indentation should be aligned
> > immediately after the open parenthesis:
> >
> > +       unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> > +                             (write ? FAULT_FLAG_WRITE : 0));
> >
> > though perhaps this is clearer as:
> >
> >        unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
> >
> >        if (write)
> >                flags |= FAULT_FLAG_WRITE;
> >
> > or even separate sets.
> >
> >        if (write)
> >                flags = foo;
> >        else
> >                flags = bar;
> 
> This is how it is in the patch file(immediately after the paramthesis).
> I have now attached both sparc patches to this email.
> 
> you must be having the same problem in viewing the patch file
> as me due to the email client itself inserting invalid spaces here and there.

Nope.  That's not it.

> by the way, what tab-spaces are you using when you open it in vim ?

I use vim as an editor as infrequently as possible.

Your original patch used 6 tabs and 2 spaces.
Tab size in kernel style is always 8.

Again, make sure your tab indentation is set to 8.