mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 12/13] Add a kerneldoc comment to spin_is_locked() that discourages its usage
Date: Tue, 27 Mar 2012 17:47:16 -0700	[thread overview]
Message-ID: <1332895637-32572-13-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1332895637-32572-1-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 include/linux/spinlock.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index 7df6c17..4805e4d 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -360,6 +360,15 @@ static inline void spin_unlock_wait(spinlock_t *lock)
 	raw_spin_unlock_wait(&lock->rlock);
 }
 
+/**
+ * spin_is_locked() - Check if a spinlock is being held.
+ * @lock: Lock to check.
+ *
+ * This function should normally not be used. Especially using it in
+ * WARN and BUG_ONs is usually incorrect or redundant.
+ * If you want to check if a lock is held in a function
+ * use lockdep_assert_held(). A lot of other usages are racy.
+ */
 static inline int spin_is_locked(spinlock_t *lock)
 {
 	return raw_spin_is_locked(&lock->rlock);
-- 
1.7.7.6


  parent reply	other threads:[~2012-03-28  0:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28  0:47 spin-is-locked is evil patchkit v2 Andi Kleen
2012-03-28  0:47 ` [PATCH 01/13] block: use lockdep_assert_held for queue locking Andi Kleen
2012-03-30 10:33   ` Jens Axboe
2012-03-28  0:47 ` [PATCH 02/13] sgi-xp: Use lockdep_assert_held Andi Kleen
2012-03-28  0:47 ` [PATCH 03/13] ada152x: Remove broken usage of spin_is_locked Andi Kleen
2012-03-28  0:47 ` [PATCH 04/13] staging/zmem: Use lockdep_assert_held instead " Andi Kleen
2012-03-28  0:47 ` [PATCH 05/13] XFS: Fix lock ASSERT on UP Andi Kleen
2012-03-29 23:21   ` Christoph Hellwig
2012-03-29 23:52     ` Andi Kleen
2012-03-30  4:13       ` Dave Chinner
2012-03-30 14:04         ` Andi Kleen
2012-03-30 14:10           ` Christoph Hellwig
2012-04-19 21:31         ` Andrew Morton
2012-03-28  0:47 ` [PATCH 06/13] huge-memory: Use lockdep_assert_held Andi Kleen
2012-03-28  0:47 ` [PATCH 07/13] futex: Use lockdep_assert_held() for lock checking Andi Kleen
2012-03-28  0:47 ` [PATCH 08/13] irda: remove spin_is_locked Andi Kleen
2012-03-28  1:32   ` David Miller
2012-03-28  0:47 ` [PATCH 09/13] usb: gadget: f_fs: Remove lock is held before freeing checks Andi Kleen
2012-04-10 10:42   ` Felipe Balbi
2012-03-28  0:47 ` [PATCH 10/13] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
2012-03-28  1:32   ` David Miller
2012-03-28  0:47 ` [PATCH 11/13] Add a discussion on why spin_is_locked() is bad to spinlocks.txt Andi Kleen
2012-03-28  8:48   ` Wolfram Sang
2012-03-28  9:07     ` Andi Kleen
2012-03-28  0:47 ` Andi Kleen [this message]
2012-03-28  8:49   ` [PATCH 12/13] Add a kerneldoc comment to spin_is_locked() that discourages its usage Wolfram Sang
2012-03-28  0:47 ` [PATCH 13/13] checkpatch: Check for spin_is_locked Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332895637-32572-13-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®