From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg K H <gregkh@linuxfoundation.org>,
Aristeu Rozanski Filho <arozansk@redhat.com>
Subject: [PATCH 00/14] Fix the EDAC API
Date: Thu, 29 Mar 2012 14:06:47 -0300 [thread overview]
Message-ID: <1333040821-6253-1-git-send-email-mchehab@redhat.com> (raw)
The EDAC API is broken for any memory controller that doesn't use
a DIMM rank as its primary unit.
That covers RAMBUS and FB-DIMM drivers, where it is impossible to
track a single rank, as the hank is hidden by a buffer controller
(AMB - Advanced Memory Buffer, in the case of FB-DIMM).
Also, newer Intel architectures (Nehalem and Sandy Bridge) brings
advanced memory controllers, where the cachesize can be different
than 128 bits, and up to 4 channels can be interlaced. The current
EDAC API doesn't work for those.
So, all drivers that need that do some sort of tricks to lie to the
EDAC core, in order for the memory to be somehow exposed. There are
several cases where this is done wrong.
The only way to fix is to create a new ABI capable of exporting what
the driver actually sees, and not some virtual information, produced
by the driver just to make the EDAC core happy.
As requested by Greg, the first step is to convert the EDAC MC code
to use struct device. That means that 3 drivers also need to be
converted (amd64, i7core and mpc85xx_edac), as they create their own
ABI's.
Those patches were compile-tested on all architectures.
It was also tested on all types of Memory Controllers with EDAC support
I was able to find at Red Hat Labs:
e752x_edac (a Xeon i3100 chipset)
i3000_edac
i3200_edac
i5000_edac
i5100_edac
i5400_edac
i7300_edac
i7core_edac (Nehalem)
sb_edac (Sandy Bridge E5)
amd64_edac
Several of them with multiple memory controllers (the amd64 hardware
I used is the bigger one, in terms of MC, with 8 memory controllers).
There are 3 intended changes that are out of this series:
- ABI documentation. I'll write the ABI patch as soon as I
merge this series at -next;
- New API UE/CE error counters. They're needed, but, as the
discussions weren't finished, let's postpone it. I'll start work on
it after the merge of this series.
- MCA error trace. Also, there wasn't any agreement yet.
So, keep this out of this series, until we come to some conclusion.
Regards,
Mauro
Mauro Carvalho Chehab (14):
edac: rewrite the sysfs code to use struct device
mpc85xx_edac: convert sysfs logic to use struct device
amd64_edac: convert sysfs logic to use struct device
i7core_edac: convert it to use struct device
edac: Get rid of the old kobj's from the edac mc code
edac: add a new per-dimm API and make the old per-virtual-rank API
obsolete
edac: add a sysfs node to report the maximum location for the system
edac: Add debufs nodes to allow doing fake error inject
edac: Create a per-Memory Controller bus
edac: Move grain/dtype/edac_type calculus to be out of channel loop
i82975x_edac: Test nr_pages earlier to save a few CPU cycles
i5100_edac: Fix a warning when compiled with 32 bits
i7300_edac: Get rid of some wrongly-solved rebase conflict
edac: Only expose csrows/channels on legacy API if they're populated
drivers/edac/Kconfig | 8 +
drivers/edac/amd64_edac.c | 43 +-
drivers/edac/amd64_edac.h | 29 +-
drivers/edac/amd64_edac_dbg.c | 89 ++--
drivers/edac/amd64_edac_inj.c | 128 +++--
drivers/edac/cpc925_edac.c | 54 +-
drivers/edac/e752x_edac.c | 31 +-
drivers/edac/e7xxx_edac.c | 32 +-
drivers/edac/edac_mc.c | 60 +-
drivers/edac/edac_mc_sysfs.c | 1322 +++++++++++++++++++++--------------------
drivers/edac/edac_module.c | 13 +-
drivers/edac/edac_module.h | 9 +-
drivers/edac/i5000_edac.c | 3 -
drivers/edac/i5100_edac.c | 4 +-
drivers/edac/i7300_edac.c | 3 -
drivers/edac/i7core_edac.c | 336 +++++++----
drivers/edac/i82875p_edac.c | 4 -
drivers/edac/i82975x_edac.c | 9 +-
drivers/edac/mpc85xx_edac.c | 93 ++--
include/linux/edac.h | 69 +--
20 files changed, 1250 insertions(+), 1089 deletions(-)
--
1.7.8
next reply other threads:[~2012-03-29 17:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 17:06 Mauro Carvalho Chehab [this message]
2012-03-29 17:06 ` [PATCH 01/14] edac: rewrite the sysfs code to use struct device Mauro Carvalho Chehab
2012-03-29 22:03 ` Greg K H
2012-03-29 23:19 ` Mauro Carvalho Chehab
2012-03-29 23:40 ` Greg K H
2012-03-30 2:13 ` Mauro Carvalho Chehab
2012-03-30 9:11 ` Borislav Petkov
2012-03-30 10:46 ` Mauro Carvalho Chehab
2012-03-30 15:32 ` Greg K H
2012-03-30 15:31 ` Greg K H
2012-03-30 17:34 ` Mauro Carvalho Chehab
2012-03-30 19:24 ` Greg K H
2012-03-29 17:06 ` [PATCH 02/14] mpc85xx_edac: convert sysfs logic " Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 03/14] amd64_edac: " Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 04/14] i7core_edac: convert it " Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 05/14] edac: Get rid of the old kobj's from the edac mc code Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 06/14] edac: add a new per-dimm API and make the old per-virtual-rank API obsolete Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 07/14] edac: add a sysfs node to report the maximum location for the system Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 08/14] edac: Add debufs nodes to allow doing fake error inject Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 09/14] edac: Create a per-Memory Controller bus Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 10/14] edac: Move grain/dtype/edac_type calculus to be out of channel loop Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 11/14] i82975x_edac: Test nr_pages earlier to save a few CPU cycles Mauro Carvalho Chehab
2012-03-29 17:06 ` [PATCH 12/14] i5100_edac: Fix a warning when compiled with 32 bits Mauro Carvalho Chehab
2012-03-29 17:07 ` [PATCH 13/14] i7300_edac: Get rid of some wrongly-solved rebase conflict Mauro Carvalho Chehab
2012-03-29 17:07 ` [PATCH 14/14] edac: Only expose csrows/channels on legacy API if they're populated Mauro Carvalho Chehab
2012-03-29 20:46 ` [PATCH 00/14] Fix the EDAC API Aristeu Rozanski Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333040821-6253-1-git-send-email-mchehab@redhat.com \
--to=mchehab@redhat.com \
--cc=arozansk@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®