From: Steven Rostedt <rostedt@goodmis.org>
To: John Kacur <jkacur@redhat.com>
Cc: Borislav Petkov <bp@amd64.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Remove a superfluous check
Date: Thu, 29 Mar 2012 13:23:54 -0400 [thread overview]
Message-ID: <1333041834.23924.186.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1203291914040.10113@tycho>
On Thu, 2012-03-29 at 19:17 +0200, John Kacur wrote:
>
> It looks okay to me. Technically it's not functionally equivalent though,
> because now when __register_ftrace_function is called directly, (in other
> paths), the test has an unlikely there. See what Steven says, otherwise,
> you can have my reviewed by.
Unlikely()s shouldn't affect things functionally, its just an
optimization hint.
Also, this check is unlikely to be true, so the hint is valid here.
-- Steve
next prev parent reply other threads:[~2012-03-29 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 16:44 Borislav Petkov
2012-03-29 17:03 ` John Kacur
2012-03-29 17:11 ` Borislav Petkov
2012-03-29 17:17 ` John Kacur
2012-03-29 17:23 ` Steven Rostedt [this message]
2012-03-29 17:26 ` Borislav Petkov
2012-05-24 16:32 ` Borislav Petkov
2012-05-24 16:41 ` Steven Rostedt
2012-05-24 17:04 ` Borislav Petkov
2012-06-20 10:38 ` [tip:perf/core] " tip-bot for Borislav Petkov
2012-03-29 17:14 ` [PATCH] " Steven Rostedt
2012-03-29 17:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333041834.23924.186.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=bp@amd64.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®