mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alok Chauhan <alokc@nvidia.com>
To: <khali@linux-fr.org>, <ben-linux@fluff.org>,
	<w.sang@pengutronix.de>, <swarren@nvidia.com>, <olof@lixom.net>,
	<bones@secretlab.ca>, <omaplinuxkernel@gmail.com>,
	<ccross@android.com>, <ldewangan@nvidia.com>,
	<linux-tegra@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	<dgreid@chromium.org>
Cc: <alokc@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] i2c: tegra: Add delay before reset the controller
Date: Fri, 30 Mar 2012 17:36:19 +0530	[thread overview]
Message-ID: <1333109179-12445-1-git-send-email-alokc@nvidia.com> (raw)

In NACK error condition, I2C controller violates
clock-to-data setup time before stop. In Software,
because of this reset of controller is happening
before I2C controller could complete STOP condition.

Added delay of 2 clock period before reset the
controller in case of NACK error.

Signed-off-by: Alok Chauhan <alokc@nvidia.com>
---
delay will be calculated based on clock frequency of the bus.
 drivers/i2c/busses/i2c-tegra.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e978635..344282e 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -516,6 +516,14 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
 	if (likely(i2c_dev->msg_err == I2C_ERR_NONE))
 		return 0;
 
+	/*
+	 * In NACK error condition resetting of I2C controller happens
+	 * before STOP condition is properly completed by I2C controller,
+	 * so wait for 2 clock cycle to complete STOP condition.
+	 */
+	if (i2c_dev->msg_err == I2C_ERR_NO_ACK)
+		udelay(DIV_ROUND_UP(2 * 1000000, i2c_dev->bus_clk_rate));
+
 	tegra_i2c_init(i2c_dev);
 	if (i2c_dev->msg_err == I2C_ERR_NO_ACK) {
 		if (msg->flags & I2C_M_IGNORE_NAK)
-- 
1.7.4.1


             reply	other threads:[~2012-03-30 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 12:06 Alok Chauhan [this message]
2012-03-30 15:54 ` Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22 10:41 Alok Chauhan
2011-12-22 21:17 ` Olof Johansson
2011-12-23 11:15   ` Alok Chauhan
2011-12-23 11:20     ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333109179-12445-1-git-send-email-alokc@nvidia.com \
    --to=alokc@nvidia.com \
    --cc=ben-linux@fluff.org \
    --cc=bones@secretlab.ca \
    --cc=ccross@android.com \
    --cc=dgreid@chromium.org \
    --cc=khali@linux-fr.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=omaplinuxkernel@gmail.com \
    --cc=swarren@nvidia.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®