From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760791AbcBYOfJ (ORCPT ); Thu, 25 Feb 2016 09:35:09 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:55011 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760412AbcBYOfG (ORCPT ); Thu, 25 Feb 2016 09:35:06 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Dmitry Eremin-Solenikov , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function Date: Thu, 25 Feb 2016 15:34:37 +0100 Message-ID: <133317017.7Cfvjc5WMX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1456238094-778916-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vkgFTefakBTcmYctKDh/lOitp33O+oE3oa5O+ZCDAS4hj9TRZLC 7jVmJfhIut7RNw5xbtjBQnlx825VxtTJgSLJg094psO4exkSPlfutMWJZ+UzYRTLyMF++Kh jkalBSvNx798NCWtec4cYUlLE2pX0/u0xPoJD1lgu0va337giXj/IQHdADWufwaenu6f/NJ khzV/qufmtdMmE24YtqlA== X-UI-Out-Filterresults: notjunk:1;V01:K0:hoKFueZtndc=:fqlw6lch4CZ+RAQMM8i+KO j/W6vMQ+4AetYFKuJAh8rLOsl2H1Gb1Jr6K3hALnVyRqE7JFqyvMkVyDj1AgM1B6VOFULllJK vv3xSd+ZW6binFdC5m9arbsmJideTnICET7P65nDq0WKYRwNGus+Vq6TnYIQ8YXfBPkjlrWzs CyI+OIqjCFyhrUnAlYkHfRP1uTMFnI5qrxIIBPQwCul8TppB9I65A+j91pu/iBG8O8m0JKGuf EB0cmwd0RLTkWY71XolRE3spsVZA3OkayhVF3qu3QhxxzBDKoZjHCySfo9Y4ExrUOSmWAkSrY 1k5cakYNh0FfGttyeKuhBKDINGudJI4g8gI+RR2dlZfcvOPal45tFNRvk+TV9vzp/fvK7PZ9R vz6AHkgtBYZEWuKAI2Ag6MYPBg4vGrLUy6eFgvcMUUCOqfy27DX/rgscYS1hsLTOQC33FumMm FnSPdDcoLUC7PbJEwPMS+JBeSF6AORhdRoYqnlsmNoOxB6UwaLqGZn2zgyVxhzOy8jbGV+2hY YRC7mrMLA6/xwTMZMH7V0Cy6ARWUhGxzZB/bFxkUNPWmQ0k+zKwqp3EsATMyQLWthVCMVU9Vd cjszWxRZL/gbhJGHWFOdHLiMD0ReZ+tiaG+uNJRGW7bfgGo6M+ti6Z7FKlj6sumVWblOwikSX PUbb53k4kRlzJaC1v/NoKubsqYd74ZVV87KEOZgG6c8n4R+iVTu62t/iDhJBvhX8lci0wEHK6 WYJKuF2ESj1RCn94 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 February 2016 14:18:44 Linus Walleij wrote: > On Tue, Feb 23, 2016 at 3:34 PM, Arnd Bergmann wrote: > > > Calling sa1100_register_uart_fns() leaves the port structure > > unused when CONFIG_SERIAL_SA1100 is disabled, and we get a > > compiler warning about that: > > > > arch/arm/mach-sa1100/badge4.c:317:31: warning: 'badge4_port_fns' defined but not used [-Wunused-variable] > > static struct sa1100_port_fns badge4_port_fns __initdata = { > > > > This turns the two empty macros into empty inline functions, > > which has the same effect, but lets the compiler know that the > > variables are intentionally unused. > > > > Signed-off-by: Arnd Bergmann > > Acked-by: Linus Walleij > > > include/linux/platform_data/sa11x0-serial.h | 8 ++++++-- > > It looks like you should send this to Greg? Yes, good point. The file was traditionally under arch/arm (or include/asm-arm before that), but considering it as part of the driver makes slightly more sense now. Sent out with a modified subject and your Ack to Greg now. Arnd