From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "Rob Herring" <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH] devicetree: pull evaluation of of_address_to_resource() out of loop in of_dev_lookup()
Date: Tue, 3 Apr 2012 14:48:28 +0200 [thread overview]
Message-ID: <1333457308-6005-1-git-send-email-LW@KARO-electronics.de> (raw)
The result of_address_to_resource(np, 0, &res) is independent from the
for (; lookup->compatible != NULL; lookup++) {
}
loop evaluation. Evaluate it once before entering the loop.
Also add a space between 'for' keyword and parens.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/of/platform.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 343ad29..528405f 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -314,11 +314,12 @@ static const struct of_dev_auxdata *of_dev_lookup(const struct of_dev_auxdata *l
if (!lookup)
return NULL;
- for(; lookup->compatible != NULL; lookup++) {
+ if (of_address_to_resource(np, 0, &res))
+ return NULL;
+
+ for (; lookup->compatible != NULL; lookup++) {
if (!of_device_is_compatible(np, lookup->compatible))
continue;
- if (of_address_to_resource(np, 0, &res))
- continue;
if (res.start != lookup->phys_addr)
continue;
pr_debug("%s: devname=%s\n", np->full_name, lookup->name);
--
1.7.2.5
next reply other threads:[~2012-04-03 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 12:48 Lothar Waßmann [this message]
[not found] ` <20120403235434.A536C3E03F3@localhost>
2012-04-04 5:57 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333457308-6005-1-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®