From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231Ab2DCXBb (ORCPT ); Tue, 3 Apr 2012 19:01:31 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:33194 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753693Ab2DCXBa (ORCPT ); Tue, 3 Apr 2012 19:01:30 -0400 Message-ID: <1333494088.2695.29.camel@joe2Laptop> Subject: Re: [PATCH] tilepro ethernet driver: fix a few minor issues From: Joe Perches To: David Miller Cc: sfr@canb.auug.org.au, cmetcalf@tilera.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Apr 2012 16:01:28 -0700 In-Reply-To: <20120403.184004.2056266545823149252.davem@davemloft.net> References: <201203302325.q2UNPm8j012403@farm-0012.internal.tilera.com> <20120403.182335.782073108961783777.davem@davemloft.net> <20120404083738.0b0f09ffc1f8c5a105c240eb@canb.auug.org.au> <20120403.184004.2056266545823149252.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-04-03 at 18:40 -0400, David Miller wrote: > From: Stephen Rothwell > Date: Wed, 4 Apr 2012 08:37:38 +1000 > > On Tue, 03 Apr 2012 18:23:35 -0400 (EDT) David Miller wrote: > >> Format the comment: > >> /* Like > >> * this. > >> */ > >> not: > >> /* > >> * Like > >> * this. > >> */ > > People may be confused because Documentation/CodingStyle says to use the > > latter ... > I refuse to be dragged into this conversation, I'm completely aware > of the exact situation and I've stated my peace on this time and time > again. I think you'd have less overall upset in yourself and in other people if you would do more than repeat yourself on patch submissions via mailing lists. To my knowledge when the comment block style was added to CodingStyle in 2006, you didn't mention anything about it. https://lkml.org/lkml/2006/12/7/41 and I don't see any other mentions from you. When I suggested adding something specifically for net and drivers/net, you were at least dispraising. http://lists.openwall.net/netdev/2012/02/04/59 I think it'd be useful to have this preference you have for block comment style written out somewhere other than the email archives. cheers, Joe