From: Mike Galbraith <mgalbraith@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: Tejun Heo <tj@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <paul@paulmenage.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] cgroups: disallow attaching kthreadd
Date: Wed, 04 Apr 2012 12:38:35 +0200 [thread overview]
Message-ID: <1333535915.7188.18.camel@marge.simpson.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1204040008040.5356@chino.kir.corp.google.com>
On Wed, 2012-04-04 at 00:15 -0700, David Rientjes wrote:
> On Tue, 3 Apr 2012, Mike Galbraith wrote:
>
> > The hazzards of moving kthreadd into a non-root cgroup is still present
> > in mainline. Last go 'round stalled with Peter not liking the
> > cpuset,cpu per controller specific exclusion. I agree that total
> > exclusion is the better option, and below is a respin doing that.
> >
>
> We've been through this several times now iterating between two different
> functional changes. I appreciate the persistence, but please, again,
> explain why you are doing this at the cgroups level rather than the
> cpusets level?
>
> The last time we discussed this, you had proposed a patch to only do this
> for cpusets after the points I'm about to bring up for the fifth time.
> Peter ended up not responding and as I remember it didn't have strong
> feelings against doing it only for cpusets. And here we are, yet again,
> back to the cgroups version.
Suggest a third version.
> There's _nothing_ wrong with attaching a kthread to most cgroups. We do
> it for memcg. And now you're trying to break it for ABSOLUTELY NO REASON.
Oh, caps made that so much more legible.
One, I don't see what it's breaking, and two, the reason for this repeat
is that the last attempt with cpuset,cpu exclusion did not fly.
I don't care how it gets fixed. I just thought I should mention that
the problem is still alive upstream, did that, and was told I should try
this way again with CCs.
Ok, so you NAK this way, Peter NAKS the other way, and the bug lives on
forever. So be it.
-Mike
next prev parent reply other threads:[~2012-04-04 10:38 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:58 Mike Galbraith
2012-04-03 18:49 ` Tejun Heo
2012-04-04 2:34 ` Mike Galbraith
2012-04-04 23:06 ` Tejun Heo
2012-04-04 23:10 ` Tejun Heo
2012-04-04 7:15 ` David Rientjes
2012-04-04 10:38 ` Mike Galbraith [this message]
2012-04-04 11:29 ` David Rientjes
2012-04-04 12:30 ` Mike Galbraith
2012-04-04 21:17 ` David Rientjes
2012-04-04 23:09 ` Tejun Heo
2012-04-04 23:14 ` David Rientjes
2012-04-05 4:47 ` Mike Galbraith
2012-04-05 4:58 ` David Rientjes
2012-04-05 5:49 ` Mike Galbraith
2012-04-05 6:07 ` David Rientjes
2012-04-05 6:42 ` Mike Galbraith
2012-04-05 6:49 ` David Rientjes
2012-04-05 7:14 ` [patch 0/2] cpusets, cpu_cgroup: " David Rientjes
2012-04-05 7:14 ` [patch 1/2] cpusets: " David Rientjes
2012-04-05 7:14 ` [patch 2/2] cpu_cgroup: " David Rientjes
2012-04-05 16:08 ` [patch 0/2] cpusets, " Tejun Heo
2012-04-05 21:26 ` David Rientjes
2012-04-05 21:37 ` Tejun Heo
2012-04-05 21:46 ` Tejun Heo
2012-04-06 7:50 ` Li Zefan
2012-04-06 15:54 ` Tejun Heo
2012-04-05 22:03 ` David Rientjes
2012-04-05 22:24 ` Tejun Heo
2012-04-05 22:31 ` Tejun Heo
2012-04-05 22:55 ` David Rientjes
2012-04-05 22:58 ` Tejun Heo
2012-04-05 23:05 ` David Rientjes
2012-04-05 23:13 ` Tejun Heo
2012-04-05 23:40 ` David Rientjes
2012-04-06 15:52 ` Tejun Heo
2012-04-06 18:26 ` Peter Zijlstra
2012-04-06 20:49 ` David Rientjes
2012-04-07 15:02 ` Hiroyuki Kamezawa
2012-04-10 0:52 ` David Rientjes
2012-04-14 11:35 ` Peter Zijlstra
2012-04-20 17:55 ` Tejun Heo
2012-04-06 20:46 ` David Rientjes
2012-04-14 11:28 ` Peter Zijlstra
2012-04-05 7:36 ` [patch] cgroups: " Mike Galbraith
2012-04-05 8:00 ` David Rientjes
2012-04-14 11:17 ` Peter Zijlstra
2012-04-05 16:11 ` Tejun Heo
2012-04-20 17:57 ` Tejun Heo
2012-04-21 5:31 ` Mike Galbraith
2012-04-21 6:54 ` Li Zefan
2012-04-21 7:13 ` Mike Galbraith
2012-04-23 18:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333535915.7188.18.camel@marge.simpson.net \
--to=mgalbraith@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=paul@paulmenage.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome