From: Mark Asselstine <mark.asselstine@windriver.com>
To: <rostedt@goodmis.org>
Cc: <linux-kernel@vger.kernel.org>, <mark.asselstine@windriver.com>
Subject: [PATCH 0/3] trace-cmd fixes for latency tracing record and report
Date: Thu, 5 Apr 2012 15:19:43 -0400 [thread overview]
Message-ID: <1333653586-3379-1-git-send-email-mark.asselstine@windriver.com> (raw)
The following three patches are for the latency-cmd tree.
trace-cmd latency tracing is broken due to segfaults and disappearing 'trace'
logs. Recent commits seem to have broken latency tracers by changing when things are
being initialized or leaving some things uninitialized since they are unused in certain
circumstances. The first two patches address segfaults when running both the record and
report commands caused by attempts to access uninitialized pointers. The last patch
avoids empty reports due to the premature clearing of the 'trace' log caused by resetting
the current_tracer to 'nop'. We still set the 'current_tracer' to 'nop', just after we
have grabbed the data we want.
These changes have been tested on top of the latest trace-cmd tree as well as
on top of the trace-cmd-v1.2 tag point in conjunction with the latest mainline
kernel as well as an older 2.6.34 vintage kernel.
Tests were done with
# ./trace-cmd record -p irqsoff ls /bin
# ./trace-cmd report
Regards,
Mark Asselstine
next reply other threads:[~2012-04-05 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 19:19 Mark Asselstine [this message]
2012-04-05 19:19 ` [PATCH 1/3] trace-cmd: add checks for invalid pointers to fix segfaults Mark Asselstine
2012-04-05 19:19 ` [PATCH 2/3] trace-cmd: don't call stop_threads() if doing latency tracing Mark Asselstine
2012-04-05 19:19 ` [PATCH 3/3] trace-cmd: setting plugin to 'nop' clears data before its recorded Mark Asselstine
2012-04-05 21:37 ` Steven Rostedt
2012-04-06 12:06 ` Mark Asselstine
2012-04-06 12:24 ` Steven Rostedt
2012-04-08 15:38 ` [PATCH v2 3/3] trace-cmd: setting plugin to 'nop' clears data before it's recorded Mark Asselstine
2012-05-23 9:33 ` Steven Rostedt
2012-05-23 13:26 ` Mark Asselstine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333653586-3379-1-git-send-email-mark.asselstine@windriver.com \
--to=mark.asselstine@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®