From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: [PATCH 2/2] regmap: mmio: remove some error checks now in the core
Date: Fri, 6 Apr 2012 15:17:33 -0600 [thread overview]
Message-ID: <1333747053-6846-2-git-send-email-swarren@wwwdotorg.org> (raw)
In-Reply-To: <1333747053-6846-1-git-send-email-swarren@wwwdotorg.org>
From: Stephen Warren <swarren@nvidia.com>
These error checks are implemented in regmap core. Remove the duplicate
code from regmap-mmio.c
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
This logically slight depends on "regmap: validate regmap_raw_read/write
val_len" that I just sent, but its not really a big deal.
drivers/base/regmap/regmap-mmio.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c
index ffa0e85..bdf4dc8 100644
--- a/drivers/base/regmap/regmap-mmio.c
+++ b/drivers/base/regmap/regmap-mmio.c
@@ -37,9 +37,6 @@ static int regmap_mmio_gather_write(void *context,
BUG_ON(reg_size != 4);
- if (val_size % ctx->val_bytes)
- return -EIO;
-
offset = be32_to_cpup(reg);
while (val_size) {
@@ -86,9 +83,6 @@ static int regmap_mmio_read(void *context,
BUG_ON(reg_size != 4);
- if (val_size % ctx->val_bytes)
- return -EIO;
-
offset = be32_to_cpup(reg);
while (val_size) {
--
1.7.0.4
next prev parent reply other threads:[~2012-04-06 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 21:17 [PATCH 1/2] regmap: mmio: convert some error returns to BUG() Stephen Warren
2012-04-06 21:17 ` Stephen Warren [this message]
2012-04-07 8:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333747053-6846-2-git-send-email-swarren@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®