mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: philipp@redfish-solutions.com,
	Bjarke Istrup Pedersen <gurligebis@gentoo.org>
Subject: [PATCH] NET5501: Change active_low to 0 for LED driver.
Date: Tue, 10 Apr 2012 23:45:38 +0000	[thread overview]
Message-ID: <1334101538-19127-1-git-send-email-gurligebis@gentoo.org> (raw)

It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.

The wiki article about it confuses it, since it contradicts
itself, regarding what turns on the LED.

I have tested 3.4-rc2 on my net5501 with this patch, and it
makes the LED behave correctly, where "none" turns it off, and
"default-on" turns it on, when echoed onto the trigger "file"
in /sys/class/leds.

Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
 arch/x86/platform/geode/net5501.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
 		.name = "net5501:1",
 		.gpio = 6,
 		.default_trigger = "default-on",
-		.active_low = 1,
+		.active_low = 0,
 	},
 };
 
-- 
1.7.8.5


             reply	other threads:[~2012-04-10 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 23:45 Bjarke Istrup Pedersen [this message]
2012-04-13 22:17 ` Bjarke Istrup Pedersen
2012-04-13 22:19   ` Philip Prindeville
2012-04-13 22:33     ` Bjarke Istrup Pedersen
2012-04-13 23:22       ` Philip Prindeville
2012-04-14  0:43         ` Bjarke Istrup Pedersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334101538-19127-1-git-send-email-gurligebis@gentoo.org \
    --to=gurligebis@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®