mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>
To: stefani@seibold.net
Cc: srinivas.kandagatla@st.com, mchehab@infradead.org,
	linux-kernel@vger.kernel.org, sfr@canb.auug.org.au
Subject: [PATCH 3.3.0] kernel:kfifo: export __kfifo_max_r symbol.
Date: Wed, 11 Apr 2012 09:01:56 +0100	[thread overview]
Message-ID: <1334131316-7992-1-git-send-email-srinivas.kandagatla@st.com> (raw)

From: Srinivas Kandagatla <srinivas.kandagatla@st.com>

kfifo_avail expands to __kfifo_max_r which is not an exported symbol.
Any kernel module using kfifo_avail will result in build failures
because of this.
This patch just exports __kfifo_max_r symbol to fix such problems in
future.

This bug was orignially reported by Stephen Rothwell <sfr@canb.auug.org.au> 
during v4l-dvb tree integration into linux-next.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
Hi All, 
A bulid failure during v4l-dvb tree integration into linux-next shows that __kfifo_max_r symbol is not exported.
All the __kifo_* functions declared in kfifo.h are already exported symbols.
I see no reason why __kfifo_max_r should not be exported too.

comments?

--srini

 kernel/kfifo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/kfifo.c b/kernel/kfifo.c
index c744b88..59dcf5b 100644
--- a/kernel/kfifo.c
+++ b/kernel/kfifo.c
@@ -402,6 +402,7 @@ unsigned int __kfifo_max_r(unsigned int len, size_t recsize)
 		return max;
 	return len;
 }
+EXPORT_SYMBOL(__kfifo_max_r);
 
 #define	__KFIFO_PEEK(data, out, mask) \
 	((data)[(out) & (mask)])
-- 
1.7.0.4


             reply	other threads:[~2012-04-11  8:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  8:01 Srinivas KANDAGATLA [this message]
2012-04-11 16:48 ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334131316-7992-1-git-send-email-srinivas.kandagatla@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®