From: Ben Hutchings <bhutchings@solarflare.com>
To: Stuart Hodgson <smhodgson@solarflare.com>
Cc: <netdev@vger.kernel.org>, <bruce.w.allan@intel.com>,
<mirq-linux@rere.qmqm.pl>, <decot@google.com>,
<amit.salecha@qlogic.com>, <alexander.h.duyck@intel.com>,
<davem@davemloft.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] net: ethtool: Add capability to retrieve plug-in module EEPROM
Date: Wed, 11 Apr 2012 19:16:57 +0100 [thread overview]
Message-ID: <1334168217.2552.5.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <4F85B639.5090900@solarflare.com>
On Wed, 2012-04-11 at 17:50 +0100, Stuart Hodgson wrote:
> On 02/04/12 18:52, Ben Hutchings wrote:
[...]
> >> --- a/net/core/ethtool.c
> >> +++ b/net/core/ethtool.c
[...]
> >> + if (eeprom.offset + eeprom.len> modinfo.eeprom_len)
> >> + return -EINVAL;
> >> +
> >> + data = kmalloc(PAGE_SIZE, GFP_USER);
> >> + if (!data)
> >> + return -ENOMEM;
> >
> > What if some device has a larger EEPROM? Surely this length should be
> > eeprom.len.
> >
>
> Do you mean what if the eeprom length in te device is larger than
> PAGE_SIZE?
Yes.
> If so then it should really use modinfo.eeprom_len since
> this the size of the data. eeprom.len could be arbitary.
No, eeprom.len is the size of the data and we've already validated it at
this point.
Ben.
next prev parent reply other threads:[~2012-04-11 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 17:51 Stuart Hodgson
2012-04-02 17:52 ` Ben Hutchings
2012-04-02 18:14 ` Ben Hutchings
2012-04-11 16:50 ` Stuart Hodgson
2012-04-11 18:16 ` Ben Hutchings [this message]
2012-04-11 23:42 ` Ben Hutchings
2012-04-12 9:18 ` Stuart Hodgson
2012-04-12 18:41 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334168217.2552.5.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=amit.salecha@qlogic.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=smhodgson@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®