From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Feng Tang <feng.tang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
santosh.shilimkar@ti.com, linux-kernel@vger.kernel.org,
johnstul@us.ibm.com
Subject: Re: [PATCH] clockevents: Leave broadcast device shtudown only if the current device is always running.
Date: Wed, 11 Apr 2012 14:01:12 -0700 [thread overview]
Message-ID: <1334178072.27381.21.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <20120411160402.GA27044@feng-i7>
On Thu, 2012-04-12 at 00:04 +0800, Feng Tang wrote:
> Thanks for the explaination, I understand the root cause now.
>
> And regarding the original commit 77b0d60c5
> clockevents: Leave the broadcast device in shutdown mode when not needed
>
> @@ -575,11 +575,15 @@ void tick_broadcast_switch_to_oneshot(void)
> unsigned long flags;
>
> raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
> + if (cpumask_empty(tick_get_broadcast_mask()))
> + goto end;
>
> tick_broadcast_device.mode = TICKDEV_MODE_ONESHOT;
> bc = tick_broadcast_device.evtdev;
> if (bc)
> tick_broadcast_setup_oneshot(bc);
> +
> +end:
> raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
> }
>
> The tick_broadcast_switch_to_oneshot() get called mostly at boot time or
> during cpu hotplug. And when it is called at boot time, the tick_broadcast_mask
> is alwasys 0 at the point,
On the correctly working platforms, that is the case. But there are
cases where APIC timer calibration fails, in which case APIC is marked
as CLOCK_EVT_FEAT_DUMMY and in this scenario, broadcast mask will be
non-zero.
> thus this check is always true and skip the
> following oneshot setting up for broadcast device,
On most platforms yes, but there are some buggy exceptions which the
code is trying to handle.
thanks,
suresh
next prev parent reply other threads:[~2012-04-11 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 6:03 Santosh Shilimkar
2012-04-09 22:41 ` Suresh Siddha
2012-04-10 6:56 ` Shilimkar, Santosh
2012-04-10 9:49 ` [tip:timers/urgent] clockevents: tTack broadcast device mode change in tick_broadcast_switch_to_oneshot() tip-bot for Suresh Siddha
2012-04-12 1:27 ` Alex Shi
2012-04-12 4:35 ` Suresh Siddha
2012-04-12 5:10 ` Alex Shi
[not found] ` <CA++bM2th5XW1gxrHbcHwDK=qBBaNc3ut0ydbNNStfNa-Xa-9tA@mail.gmail.com>
2012-04-11 6:34 ` [PATCH] clockevents: Leave broadcast device shtudown only if the current device is always running Feng Tang
2012-04-11 10:10 ` Thomas Gleixner
2012-04-11 16:04 ` Feng Tang
2012-04-11 21:01 ` Suresh Siddha [this message]
2012-04-15 12:57 ` Santosh Shilimkar
2012-04-16 22:03 ` Suresh Siddha
2012-04-17 8:14 ` Santosh Shilimkar
2012-04-17 19:11 ` Suresh Siddha
2012-04-18 5:41 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334178072.27381.21.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=feng.tang@intel.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®